Skip to content

[RFC] Topology for synchronize playback #2542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lgirdwood merged 4 commits into from
Mar 17, 2020
Merged

[RFC] Topology for synchronize playback #2542

lgirdwood merged 4 commits into from
Mar 17, 2020

Conversation

@bardliao
Copy link
Collaborator

@bardliao bardliao commented Mar 13, 2020

The PR is to implement a topology for synchronize playback. We use demux to duplicate audio data for two DAIs.

@bardliao bardliao mentioned this pull request Mar 13, 2020
Closed
lgirdwood
lgirdwood requested changes Mar 13, 2020
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more comments.

tools/topology/m4/dai.m4 Outdated
Copy link
Member

@lgirdwood lgirdwood Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comments here on usage and what its for.

tools/topology/sof/pipe-simple-playback.m4 Outdated
Copy link
Member

@lgirdwood lgirdwood Mar 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this to pipe-dai-playback.m4

Copy link
Collaborator Author

@bardliao bardliao Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we rename this to pipe-dai-playback.m4

There is another pipe-dai-playback.m4 in the same folder already.

Copy link
Member

@lgirdwood lgirdwood Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pipe-dai-endpoint

@bardliao bardliao force-pushed the topology-for-synchronize-playback branch from aacf770 to 70b0a19 Compare March 16, 2020 03:10
@bardliao
topology: dai: add DAI_ADD_SCHED to set scheduling component
6baecb8 
So we can set scheduling component when adding a DAI.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@bardliao bardliao force-pushed the topology-for-synchronize-playback branch from 70b0a19 to f3342c0 Compare March 16, 2020 03:34
ranj063
ranj063 reviewed Mar 16, 2020
View reviewed changes
tools/topology/sof/pipe-simple-playback.m4 Outdated
Copy link
Collaborator

@ranj063 ranj063 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment is wrong

Copy link
Collaborator

@ranj063 ranj063 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides this is hardly a pipeline with the SectionGraph defined elsewhere. All you have is a buffer?

Copy link
Collaborator Author

@bardliao bardliao Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides this is hardly a pipeline with the SectionGraph defined elsewhere. All you have is a buffer?

I will have a buffer with a pipeline id which is required for connecting to a demux.

ranj063
ranj063 reviewed Mar 16, 2020
View reviewed changes
tools/topology/sof/pipe-dai-sched-playback.m4 Outdated
Copy link
Collaborator

@ranj063 ranj063 Mar 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed if you're not using the N_DAI_OUT here?

Copy link
Collaborator Author

@bardliao bardliao Mar 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed if you're not using the N_DAI_OUT here?

Yeah, we don't need it. Thanks @ranj063

@bardliao bardliao mentioned this pull request Mar 17, 2020
Closed
bardliao added 3 commits March 17, 2020 14:42
@bardliao
topology: add pipe-dai-sched-playback
d845939 
This is basically the same as pipe-dai-playback.m4, but use SCHED_COMP
instead of N_DAI_OUT.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@bardliao
topology: add pipe-dai-endpoint
03b63f7 
This will create a basic pipeline with a buffer only. Note that
we don't implement a SectionGraph to connect the buffer to its
starting component, we should define it manually.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@bardliao
topology: sof-icl-rt711-rt1308-rt715-hdmi: Merge two pipeline with demux
e1ec084 
Now kernel expots one PCM with two CPU dais. So use demux to play
with two DAIs.

Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
@bardliao bardliao force-pushed the topology-for-synchronize-playback branch from f3342c0 to e1ec084 Compare March 17, 2020 06:43
@lgirdwood lgirdwood merged commit 5e8de9f into thesofproject:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranj063 ranj063 ranj063 left review comments

@lgirdwood lgirdwood lgirdwood approved these changes

@xiulipan xiulipan Awaiting requested review from xiulipan

@tlauda tlauda Awaiting requested review from tlauda

@slawblauciak slawblauciak Awaiting requested review from slawblauciak

@dbaluta dbaluta Awaiting requested review from dbaluta

@jajanusz jajanusz Awaiting requested review from jajanusz

@lbetlej lbetlej Awaiting requested review from lbetlej

@mmaka1 mmaka1 Awaiting requested review from mmaka1

@plbossart plbossart Awaiting requested review from plbossart

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bardliao @ranj063 @lgirdwood