dma-trace: allocate trace buffer only after enabling traces #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allocates DMA trace buffer only after IPC to enable traces is sent. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Collaborator
|
Tentative revert in #4334 |
marc-hb
added a commit
to marc-hb/sof
that referenced
this pull request
Feb 17, 2022
A logical, not "real" git revert of commit eca2089 ("dma-trace: allocate trace buffer only after enabling traces") Move dma_trace_buffer_init() away from dma_trace_enable() and back to dma_trace_init_early() Restore the early traces removed by that commit. There was no rationale in the commit message and it was merged without review in PR thesofproject#255. Earlier refactorings tried hard to trace early: - commit 36e425e ("dma-trace: move to earlier initialisation point") - commit 2b86cb3 ("trace: dma: Make sure we can trace platform device initialisation.") ... so it's really not clear why early tracing was removed later. "Rage quit" to avoid unidentified bugs? This could have been to save one or two 4k HOST_PAGE_SIZE when the kernel does not enable DMA traces but I can't see what real-world use case would leverage such savings _at run-time_; what happens then when the user changes her mind? We don't have any validation for a use case so dynamic. Tracing can be disabled at _compile-time_, recently fixed by commit 571cc29 ("xtensa/cmake: fix !CONFIG_TRACE") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocates DMA trace buffer only after IPC to enable traces
is sent.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com