Skip to content

Conversation

@dabekjakub
Copy link
Member

Added tests for pipeline complete and subsequently to
pipeline connect upstream and connect downstream since
they are both statics.

Signed-off-by: Jakub Dabek jakub.dabek@linux.intel.com

Added tests for pipeline complete and subsequently to
pipeline connect upstream and connect downstream since
they are both statics.

Signed-off-by: Jakub Dabek <jakub.dabek@linux.intel.com>
Copy link
Contributor

@jajanusz jajanusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In other files test names had name convention like test_<header_folder><header_name>_<what_is_tested>, but we may drop <header_name> from that pattern because functions should be already prefixed with it to avoid conflicts and we will have more readable names instead of something like ...pipeline_pipeline_connect..., ...list_list_init... etc

@lgirdwood lgirdwood merged commit 873185d into thesofproject:master Aug 24, 2018
ranj063 added a commit to ranj063/sof that referenced this pull request Mar 23, 2021
Add the class definition for a mixer control.
A mixer control can be instantiated as follows:
	Object.mixer."0" {
		#Channel register and shift for Front Left/Right
		Object.channel."0" {
			name	"fl"
			shift	0
		}
		Object.channel."1" {
			name	"fr"
		}

		Object.tlv."0" {
			name	"vtlv_m64s2"
			Object.scale."0" {
				name	"m64s2"
				mute	1
			}
		}

		Object.ops."0" {
			name	"ctl"
			info	"volsw"
			thesofproject#256 binds the mixer control to volume get/put handlers
			get	256
			put	256
		}
	}

Also add the other commonly used class definitions that
will be used to instantiate the mixer object such as,
channel, TLV, ops, scale etc.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063 added a commit to ranj063/sof that referenced this pull request Apr 3, 2021
Add the class definition for a mixer control.
A mixer control can be instantiated as follows:
	Object.mixer."0" {
		#Channel register and shift for Front Left/Right
		Object.channel."0" {
			name	"fl"
			shift	0
		}
		Object.channel."1" {
			name	"fr"
		}

		Object.tlv."0" {
			name	"vtlv_m64s2"
			Object.scale."0" {
				name	"m64s2"
				mute	1
			}
		}

		Object.ops."0" {
			name	"ctl"
			info	"volsw"
			thesofproject#256 binds the mixer control to volume get/put handlers
			get	256
			put	256
		}
	}

Also add the other commonly used class definitions that
will be used to instantiate the mixer object such as,
channel, TLV, ops, scale etc.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants