hda: retrieve hda hardware params from ipc #2765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an analogous change to what's been done for ALH DAIs. Similarly, HDA is set up on the host side. As a result, the firmware normally has no knowledge of the hardware configuration, which leads to failures in components, that may modify stream parameters, such as (de)mux or asrc. Signed-off-by: Slawomir Blauciak <slawomir.blauciak@linux.intel.com>
The old trace message contained an SSP-specific string, which is not correct for ALH. Signed-off-by: Slawomir Blauciak <slawomir.blauciak@linux.intel.com>
slawblauciak
requested review from
a team,
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
tlauda
as code owners
![monocodus[bot]](https://avatars.githubusercontent.com/in/28526?s=60&v=4){kind=small}
Collaborator
|
Kernel side PR is reviewed/approved and ready to go -> thesofproject/linux#2007 |
Member
|
@kv2019i what Minor ? |
Collaborator
ABI 16 as per classifier. |
Member
|
@kv2019i ok great , we are aligned. Will need to hold off applying as one more 15 has been added and not merged for v1.5 release fix. |
lgirdwood
requested changes
Apr 16, 2020
| /** \brief SOF ABI version major, minor and patch numbers */ | ||
| #define SOF_ABI_MAJOR 3 | ||
| #define SOF_ABI_MINOR 15 | ||
| #define SOF_ABI_MINOR 16 |
Member
There was a problem hiding this comment.
@slawblauciak Lets make this 15 so we dont need to block. I will update the ABI table.
Member
There was a problem hiding this comment.
NAK that, kernel is already merged. Will change back to 16 and others to 16.
lgirdwood
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an analogous change to what's been done for ALH DAIs.
Similarly, HDA is set up on the host side.
As a result, the firmware normally has no knowledge
of the hardware configuration, which leads to failures
in components, that may modify stream parameters, such as
(de)mux or asrc.
Kernel side PR: thesofproject/linux#2007