mux: select demux proc function based on source buffer #2789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akloniex
reviewed
Apr 17, 2020
Member
akloniex
left a comment
akloniex
left a comment
There was a problem hiding this comment.
@bkokoszx I think that it might be most beneficial and flexible, to check whether HW params were set, before deciding which buffer to take params from.
Also, similar check could be then added to mux processing function selection.
Member
|
@keyonjie will your param update fix this ? |
Contributor
Yes, I think so. |
Member
Collaborator
Author
|
@lgirdwood |
Demux should select proc func based on source buffer, because sink can be not set yet (e.g. this can be observed in Smart Amplifier topology scenario where we have buffer between playback and capture pipeline). Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
bkokoszx
force-pushed
the
demux-set-proc-function
branch
from
3d74d1c to
bc34d98
Compare
akloniex
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demux should select proc func based on source buffer,
because sink can be not set yet (e.g. this can be observed
in smart amplifier topology scenario where there is
buffer between playback and capture pipeline).
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com