ext_man: Port SOF_IPC_EXT_WINDOW to extended manifest #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktrzcinx
requested review from
a team,
RanderWang,
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
plbossart,
tlauda and
xiulipan
as code owners
lgirdwood
requested changes
May 7, 2020
src/include/ipc/info.h
Outdated
Member
Author
There was a problem hiding this comment.
Used toolchain reject packing variable-size structures inside another one, even as last field - same situation as it was before for CC_VERSION
ktrzcinx
changed the title
ktrzcinx
changed the title
lgirdwood
approved these changes
May 18, 2020
Such a macro can be used to port .fw_ready structures to .fw_metadata section with proper header. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
This information known at build time does not need to be provided in a mailbox. There was need to remove variable array from sof_ipc_window, what give possibility to embed this struct inside another one, but leads to ABI minor change. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Member
Author
|
I resolved conflicts |
lgirdwood
changed the title
Member
|
Need to align MINOR ABI prior to merging. |
Member
Author
|
@lgirdwood I can't see any issue with ABI number, as I see I updated from 3.16.0 (master ABI) to 3.17.0, what is aligned with changes from thesofproject/linux#2087 |
Member
kv2019i
approved these changes
Jun 4, 2020
Collaborator
lgirdwood
changed the title
lgirdwood
changed the title
lgirdwood
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This information known at build time does not need to be
provided in a mailbox.
thesofproject/linux#2087