Skip to content

Conversation

@xiulipan
Copy link
Contributor

This test topology test with 4ch to 2ch demux.

Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com

This test topology test with 4ch to 2ch demux.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
@juimonen
Copy link

@xiulipan so what's the idea with channels, so which channel is copied to where? Now the matrix seems to indicate copy input channels 1 & 2 to output 1 & 2. input channels 3 & 4 are not copied anywhere... is this the purpose? So you only want to extract 1&2 from input to output?

@xiulipan
Copy link
Contributor Author

@juimonen Yes, that was the use case for the SMART_AMP and DEMUX.

@lgirdwood
Copy link
Member

@xiulipan can you make this clear in PR and topology comments that chans 3 & 4 are dropped.
Btw, if you are looking at demux can you remove the mixing from it #2687 before anybody uses it. It's very inefficient code.

@xiulipan
Copy link
Contributor Author

@lgirdwood Got that will update the the comments.
Will try to raise the issue in bug scrape meeting to remove the mixing.

# Buffers use s16le format, 1000us deadline on core 0 with priority 0
DAI_ADD(sof/pipe-dai-playback.m4,
1, SSP, 0, NoCodec-0,
PIPELINE_SOURCE_1, 2, s16le,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiulipan
I have one question, maybe I am missing something. Why we set here DAI format to s16le? Maybe better it will be to set DAI and SSP TDM format to s32_le. In that case, DAI will make PCM conversion if required. In #2959 case, when we will try to play s16, DAI should make conversion from s16 to s32.

@zrombel
Copy link

zrombel commented Aug 1, 2020

Due to recent PR #3194 merge, please rebase for TGL Multicore tests to Pass on Internal CI.

@lgirdwood
Copy link
Member

@xiulipan ping ?

@xiulipan xiulipan closed this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants