trace: Put global trace context entries to separate section #2996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktrzcinx
requested review from
RanderWang,
akloniex,
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
lyakh,
mmaka1,
plbossart,
tlauda and
xiulipan
as code owners
ktrzcinx
force-pushed
the
logger-tctx-section
branch
from
b9de9a1 to
feb67ea
Compare
dbaluta
reviewed
May 29, 2020
src/include/sof/trace/trace.h
Outdated
Collaborator
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I extended commit description
ktrzcinx
force-pushed
the
logger-tctx-section
branch
from
feb67ea to
710627d
Compare
dbaluta
approved these changes
May 29, 2020
dbaluta
approved these changes
May 29, 2020
lgirdwood
approved these changes
Jun 1, 2020
Member
|
@ktrzcinx can you check CI |
RanderWang
approved these changes
Jun 1, 2020
To allow changing trace level of global elements, like system agent or component driver, than it must be possible to find corresponding trace context. It is the first step to allow iterating over the trace context entries and find what we are looking for. Linker variables _trace_ctx_start and _trace_ctx_end will be needed to know this section size in runtime code. Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
ktrzcinx
force-pushed
the
logger-tctx-section
branch
from
710627d to
74bc4be
Compare
Member
Author
|
Small fix was needed - do not specify target section during unit test build. Now should be ok. |
Member
Member
Author
|
Response for Liam question is in #2920 (comment) |
Contributor
@lgirdwood I think this is for trace section only, there should be no dependency to mine. |
marc-hb
added a commit
to marc-hb/zephyr
that referenced
this pull request
Dec 15, 2021
The CAVS linker scripts in Zephyr and "plain" (XTOS) SOF seem to share the same origin and they mostly duplicate each other so they naturally keep diverging from each other. This commit catches up with the SOF commit ef43899c580f (thesofproject/sof/pull/2996) which added the *(.trace_ctx) sections as part of the runtime log filtering implementation (feature request thesofproject/sof/issues/2172) Paraphrasing that commit, the goal is to create at link time a C-like array by regrouping scattered trace contexts so they can be iterated on. Together with some other changes in SOF, these 3 additional lines are enough change in Zephyr to fix SOF bug thesofproject/sof/issues/5032 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
MaureenHelm
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Dec 16, 2021
The CAVS linker scripts in Zephyr and "plain" (XTOS) SOF seem to share the same origin and they mostly duplicate each other so they naturally keep diverging from each other. This commit catches up with the SOF commit ef43899c580f (thesofproject/sof/pull/2996) which added the *(.trace_ctx) sections as part of the runtime log filtering implementation (feature request thesofproject/sof/issues/2172) Paraphrasing that commit, the goal is to create at link time a C-like array by regrouping scattered trace contexts so they can be iterated on. Together with some other changes in SOF, these 3 additional lines are enough change in Zephyr to fix SOF bug thesofproject/sof/issues/5032 Signed-off-by: Marc Herbert <marc.herbert@intel.com>
coreboot-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Dec 21, 2021
The CAVS linker scripts in Zephyr and "plain" (XTOS) SOF seem to share the same origin and they mostly duplicate each other so they naturally keep diverging from each other. This commit catches up with the SOF commit ef43899c580f (thesofproject/sof/pull/2996) which added the *(.trace_ctx) sections as part of the runtime log filtering implementation (feature request thesofproject/sof/issues/2172) Paraphrasing that commit, the goal is to create at link time a C-like array by regrouping scattered trace contexts so they can be iterated on. Together with some other changes in SOF, these 3 additional lines are enough change in Zephyr to fix SOF bug thesofproject/sof/issues/5032 (cherry picked from commit 9a1c5ec) Signed-off-by: Marc Herbert <marc.herbert@intel.com> GitOrigin-RevId: 9a1c5ec Change-Id: I5ecc06b5e5a7bd208cf6cdea4aa91c31bd4b25ec Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/3347405 Tested-by: CopyBot Service Account <copybot.service@gmail.com> Reviewed-by: Tristan Honscheid <honscheid@google.com> Commit-Queue: Tristan Honscheid <honscheid@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the first step to allow iterating over the trace context
entries and of search for the right one.
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com
It's a part of #2965