build: add name for ADL fw #3204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename the FW name to sof-adls.ri in alderlake_s_defconfig old name sof-tgl.ri can make confusion. Need a split new name for different FW. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
xiulipan
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
tlauda
as code owners
plbossart
requested changes
Jul 17, 2020
| @@ -1,4 +1,5 @@ | |||
| CONFIG_TIGERLAKE=y | |||
| CONFIG_FIRMWARE_SHORT_NAME="adls" | |||
Member
There was a problem hiding this comment.
why do we need different firmware if it's the same hardware configuration? I think we need to stop doing this, the mix and match of cpus/chipsets force us to use the chipset configuration and ignore what platform/cpu gets used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rename the FW name to sof-adls.ri in alderlake_s_defconfig
old name sof-tgl.ri can make confusion. Need a split new
name for different FW.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com