Skip to content

audio: Add Crossover Filter component #3263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 6 commits into from
Sep 2, 2020
Merged

audio: Add Crossover Filter component #3263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e41e639
sof: math: move iir_df2t function to src/math
johnylin76 Aug 11, 2020
b790da3
sof: crossover: Add Crossover component
sebcarlucci Apr 16, 2020
1c3e546
tools: topology: Add crossover topology files
sebcarlucci Apr 16, 2020
bbcb9ad
tools: tune: Add tools to generate ctrl bytes for Crossover
sebcarlucci Apr 17, 2020
903e466
tools: tplg_parser: Add Crossover component
johnylin76 Jul 31, 2020
bddf48e
tools: testbench: add Crossover component tests
johnylin76 Aug 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ src/audio/tone.c @singalsu
src/audio/kpb.c @mrajwa
src/audio/mux/* @akloniex
src/audio/dcblock* @cujomalainey @dgreid
src/audio/crossover* @cujomalainey @dgreid

# platforms
src/arch/xtensa/* @tlauda
Expand Down
8 changes: 6 additions & 2 deletions src/audio/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ if(NOT CONFIG_LIBRARY)
if(CONFIG_COMP_DCBLOCK)
add_subdirectory(dcblock)
endif()
if(CONFIG_COMP_CROSSOVER)
add_subdirectory(crossover)
endif()
if(CONFIG_COMP_TONE)
add_local_sources(sof
tone.c
Expand Down Expand Up @@ -112,15 +115,16 @@ check_optimization(fma -mfma -DOPS_FMA)
check_optimization(hifi2ep -mhifi2ep -DOPS_HIFI2EP)
check_optimization(hifi3 -mhifi3 -DOPS_HIFI3)

set(sof_audio_modules volume src asrc eq-fir eq-iir dcblock)
set(sof_audio_modules volume src asrc eq-fir eq-iir dcblock crossover)

# sources for each module
set(volume_sources volume/volume.c volume/volume_generic.c)
set(src_sources src/src.c src/src_generic.c)
set(asrc_sources asrc/asrc.c asrc/asrc_farrow.c asrc/asrc_farrow_generic.c)
set(eq-fir_sources eq_fir/eq_fir.c eq_fir/fir.c)
set(eq-iir_sources eq_iir/eq_iir.c eq_iir/iir.c eq_iir/iir_generic.c)
Copy link
Contributor

@cujomalainey cujomalainey Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this method of moving into math still worries me because won't we need to move the crossover into the math sections as well once we start building the multiband DRC?

Copy link
Contributor

@cujomalainey cujomalainey Aug 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am noticing that all the libraries are linked back to SOF but not cross-linked, I wonder if we need need to add a case for cross linking libs

Copy link
Member

@lgirdwood lgirdwood Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu can you give us your 2c here on the maths library, which functions still need to go in it. Do you have a rough plan of how it should look ? This should mostly be code moving, or is there some coupling that prevents a code move today ?

set(eq-iir_sources eq_iir/eq_iir.c eq_iir/iir.c)
set(dcblock_sources dcblock/dcblock.c dcblock/dcblock_generic.c)
set(crossover_sources crossover/crossover.c crossover/crossover_generic.c)

foreach(audio_module ${sof_audio_modules})
# first compile with no optimizations
Expand Down
8 changes: 8 additions & 0 deletions src/audio/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@ config COMP_SEL
help
Select for SEL component

config COMP_CROSSOVER
bool "Crossover Filter component"
default n
Copy link
Contributor Author

@johnylin76 johnylin76 Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deconfig it, thanks.

help
Select for Crossover Filter component. A crossover can be used to
split a signal into two or more frequency ranges, so that the outputs
can be sent to drivers that are designed for those ranges.

config COMP_DCBLOCK
bool "DC Blocking Filter component"
default y
Expand Down
2 changes: 2 additions & 0 deletions src/audio/crossover/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
add_local_sources(sof crossover.c)
add_local_sources(sof crossover_generic.c)
Loading