[WIP][RFC] add enum control to topology and test multiple controls with iir #3396
Conversation
Add m4 macros to generate enumerated control. Usage is similar to mixer and bytes control except enumerated values are specified using separate text section. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
Add additional enum control to dmic iir pipeline. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
Add switch cases and debug messages for enum control to iir. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
juimonen
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1,
plbossart and
singalsu
as code owners
|
btw, I think this needs latest and greatest alsa-lib (it has enum control patches on top) related driver PR: |
|
@juimonen looks good, I guess we can roll this out to demux after v1.6 |
|
@lgirdwood, yes after 1.6... |
| define(DEF_EQIIR_COEF, concat(`eqiir_coef_', PIPELINE_ID)) | ||
| define(DEF_EQIIR_PRIV, concat(`eqiir_priv_', PIPELINE_ID)) | ||
|
|
||
| define(DEF_EQIIR_ENUM, concat(`eqiir_enum_', PIPELINE_ID)) |
There was a problem hiding this comment.
Minor, this could be undefined in the end of macro.
| DEF_EQIIR_PRIV) | ||
|
|
||
| # EQ enum list | ||
| CONTROLENUM_LIST(eq_preset, LIST(` ', `"preset1"', `"preset2"')) |
There was a problem hiding this comment.
This would be better as DEF_EQ_PRESET with pipeline number appended to eq_preset_. The enum items count seems to grow with number of instances.
|
@juimonen ping - would like to merge for v1.7 |
|
@juimonen ping - maybe for v1.8 ? |
|
@lgirdwood this was the first experiment with enums (with existing component like iir, didn't have beamformer then). Enum stuff is handled in other PR's, so I'll close this for now. If enums are needed for eq's, we can add later. |
3 participants
This PR is experimenting with having multiple different type controls
in a single widget. So add enum control and test iir with simultaneous
enum and byte control.