Skip to content

[RFC]ext_man: fix size issue for ext_man_config_data elem #3527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xiulipan wants to merge 1 commit into from
Closed

[RFC]ext_man: fix size issue for ext_man_config_data elem #3527

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/include/kernel/ext_manifest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ enum ext_man_elem_type {

/* EXT_MAN_ELEM_CONFIG_DATA elements identificators */
enum config_elem_type {
EXT_MAN_CONFIG_FIRST_ELEM = 1,
EXT_MAN_CONFIG_IPC_MSG_SIZE = 1,
EXT_MAN_CONFIG_MEMORY_USAGE_SCAN = 2, /**< ABI3.18 */
EXT_MAN_CONFIG_LAST_ELEM, /**< keep it at the end of enum list */
Expand Down Expand Up @@ -95,7 +96,7 @@ struct ext_man_dbg_abi {
struct ext_man_config_data {
struct ext_man_elem_header hdr;

struct config_elem elems[EXT_MAN_CONFIG_LAST_ELEM];
struct config_elem elems[EXT_MAN_CONFIG_LAST_ELEM - EXT_MAN_CONFIG_FIRST_ELEM];
Copy link
Collaborator

@kv2019i kv2019i Oct 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, starts to be a convoluted to me. I didn't pay attention when the "LAST_ELEM" was added, so without context of the prior discussions, I'd say simple "struct config_elem elems[EXT_MAN_CONFIG_LAST_ELEM - 1];" would be simple enough.

Copy link
Contributor Author

@xiulipan xiulipan Oct 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i This would be easy for view and later change. You will no longer need to update the 1 to other values if you change the ENUM or add some comments here to say: "the enum starts at 1"

} __packed;

#endif /* __KERNEL_EXT_MANIFEST_H__ */