abi: fix macro size overflow #3543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Member
|
CI showing what looks like a CI failure. |
lgirdwood
approved these changes
Oct 22, 2020
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@plbossart @kv2019i this will be needed in kernel too.
Contributor
Author
|
FYI this is blocking oss-fuzz integration as this crashes the fuzzer on first iteration everytime |
Contributor
Author
|
Related kernel PR is here, I spotted another overflow just by code inspection, will update this PR as well |
ubsan found the following bug via oss-fuzz /src/sof/src/ipc/handler.c:1385:9: runtime error: left shift of 15 by 28 places cannot be represented in type 'int' This is caused by SOF_GLB_TYPE_MASK which has an implicit length of 15 (int16_t) Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
lgirdwood
approved these changes
Oct 23, 2020
Member
|
@cujomalainey is there a similar kernel fix ? |
Contributor
Author
|
@lgirdwood see link in last comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubsan found the following bug via oss-fuzz
/src/sof/src/ipc/handler.c:1385:9: runtime error: left shift of 15 by 28 places cannot be represented in type 'int'
This is caused by SOF_GLB_TYPE_MASK which has an implicit length of 15
(int16_t)
Signed-off-by: Curtis Malainey cujomalainey@chromium.org