dai: add fall through markers for clang #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
draft till results of CI come back |
Contributor
Author
|
Excellent, gcc and clang are fine, but xcc is having a temper tantrum. @lgirdwood got any ideas? Should I just use a macro to add this only on clang/fuzz builds? |
for some reason the clang version with oss-fuzz doesn't recognize the comments so lets add this attributes in the meantime. XCC does not like them so lets only use them with clang. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
cujomalainey
requested review from
dbaluta,
jajanusz,
lbetlej,
mmaka1 and
plbossart
as code owners
Merged
lgirdwood
approved these changes
Dec 8, 2020
2 tasks
Contributor
Author
|
Friendly ping on this as it is last blocking CL to start automated fuzzing |
Member
|
@cujomalainey apologies - CI backlog, seems to be clearning now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason the clang version with oss-fuzz doesn't recognize the
comments so lets add this attributes in the meantime. xtensa-gcc doesn't
seem to mind them.
Signed-off-by: Curtis Malainey cujomalainey@chromium.org