-
Notifications
You must be signed in to change notification settings - Fork 349
mixer: dont stop mixer on pause #3618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mixer: dont stop mixer on pause #3618
Conversation
This will allow to write zeros to the buffer without reference to a source buffer Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this also when one stream is stopped ? or are we doing something different in this case ?
Btw, is there a similar update for demux ?
If only one stream is stopped mixer already can handle this, we will only not stop mixer ppl |
plbossart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the logic can be improved a bit?
|
@abonislawski ping ? |
|
@abonislawski ping - need this fix for v1.7 |
Dont stop mixer on pause and write zeros if all sources are inactive Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
c46564e to
4ea9c92
Compare
|
@lgirdwood PR updated |
|
@abonislawski I think we are at limit of byt memory - and checking I can see we are missing a in it's kconfig (as CHT has this). Can you inlcude this fix in your PR. I think we are good to then merge. Thanks ! |
Remove tone from the byt defconfig to reduxe code size. Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
|
@lgirdwood sure, added this to byt config |
audio_stream: add function writing zeros to the buffer without reference to a source buffer
mixer: dont stop mixer on pause and write zeros if all sources are inactive
Fixes #3522