Skip to content

Conversation

@abonislawski
Copy link
Member

audio_stream: add function writing zeros to the buffer without reference to a source buffer
mixer: dont stop mixer on pause and write zeros if all sources are inactive

Fixes #3522

This will allow to write zeros to the buffer without
reference to a source buffer

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this also when one stream is stopped ? or are we doing something different in this case ?
Btw, is there a similar update for demux ?

@abonislawski
Copy link
Member Author

Will this also when one stream is stopped ? or are we doing something different in this case ?
Btw, is there a similar update for demux ?

If only one stream is stopped mixer already can handle this, we will only not stop mixer ppl
No info about demux

Copy link
Member

@plbossart plbossart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logic can be improved a bit?

@lgirdwood
Copy link
Member

@abonislawski ping ?

@lgirdwood lgirdwood added this to the v1.7 milestone Dec 2, 2020
@lgirdwood
Copy link
Member

@abonislawski ping - need this fix for v1.7

Dont stop mixer on pause and write zeros
if all sources are inactive

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
@abonislawski
Copy link
Member Author

@lgirdwood PR updated

@lgirdwood
Copy link
Member

@abonislawski I think we are at limit of byt memory - and checking I can see we are missing a

CONFIG_COMP_TONE=n

in it's kconfig (as CHT has this). Can you inlcude this fix in your PR. I think we are good to then merge. Thanks !

Remove tone from the byt defconfig to reduxe code size.

Signed-off-by: Adrian Bonislawski <adrian.bonislawski@linux.intel.com>
@abonislawski
Copy link
Member Author

@lgirdwood sure, added this to byt config

@lgirdwood lgirdwood merged commit 7daaa51 into thesofproject:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] IPC error during pause/start test with multiple mixer sources

3 participants