mux: fix input and output channel setting #3674
Conversation
|
@bkokoszx FYI. Don't we have the input/output setting reversed currently? With this change I get the correct output with my testing at least... |
src/audio/mux/mux_generic.c
Outdated
There was a problem hiding this comment.
Does it make more sense to rename j and m as row and column ?
There was a problem hiding this comment.
ping. if you can fix and re-push this will let CI do a full run too.
There was a problem hiding this comment.
@juimonen
I have a concern, because as I understand correctly mask[j] corresponding to j channel on output, as we can see in code before your change. I suspect that if we hit some swapped channels issue, we may have problem somewhere else.
|
@akloniex your thoughts on this as original mux/demux author? |
|
SOFCI TEST |
|
@juimonen ping - can you check CI. |
|
@juimonen |
|
@juimonen can you check CI. UT failed. |
juimonen
force-pushed
the
mux_index_fix
branch
from
493de07 to
7470d19
Compare
juimonen
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
juimonen
force-pushed
the
mux_index_fix
branch
from
7470d19 to
a3afda4
Compare
|
SOFCI TEST |
juimonen
force-pushed
the
mux_index_fix
branch
from
a3afda4 to
6cfc638
Compare
Input and output channel settings from matrix row and column are in reverse order, so they should be swapped. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
juimonen
force-pushed
the
mux_index_fix
branch
from
6cfc638 to
b1b31e7
Compare
3 participants
Input and output channel settings from matrix row and column
are in reverse order, so they should be swapped.
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com