topology: fix setting mux uuid in m4 #3688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the mux/demux uuid setting doesn't work and uuid is always set to "demux". Fix this by quoting the ifelse in 1 line. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
juimonen
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Author
|
@libinyang FYI... |
keyonjie
reviewed
Dec 15, 2020
| ifelse(`$2', `0', | ||
| ` SOF_TKN_COMP_UUID' STR(mux_uuid), | ||
| ` SOF_TKN_COMP_UUID' STR(demux_uuid)) | ||
| `ifelse(`$2', `0',` SOF_TKN_COMP_UUID' STR(mux_uuid),` SOF_TKN_COMP_UUID' STR(demux_uuid))' |
Contributor
There was a problem hiding this comment.
so it's actually a pair of ` and' to include the whole ifelse sentence is needed, no matter how much lines it occupies?
Author
There was a problem hiding this comment.
@Keyon I guess so, I noticed that the string "mux/demux" setting below works, but this part didn't. I was debugging this for 3 days, since the string shows it is "MUX", but I never looked at the uuid. In the fw mux/demux share almost all function pointers, only copy function is different -> when copy crashed, the log was missing the last bits -> I didn't understand I was actually running demux instead of mux...
Closed
lgirdwood
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the mux/demux uuid setting doesn't work and uuid is always set
to "demux". Fix this by quoting the ifelse in 1 line.
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com