Skip to content

Conversation

@juimonen
Copy link

Currently you can't play multiple simultaneous streams at the same time
into mux. Fix this by copying the trigger and reset mechanism from audio
mixer.

Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com

@juimonen juimonen requested a review from akloniex as a code owner December 15, 2020 16:46
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly question here. So MUX is a component that allows to select one output stream from multiple input sources?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mux defined in "ASoC sense" will do what you said. Sof mux can basically pick any channels from all input streams (also duplication), but it will not mix any input channels. So it does a little bit more, than you might see in some ASoC slides in the internet. Hence it is not defined as asoc mux, but as generic processing component.

@juimonen
Copy link
Author

@libinyang FYI...

@juimonen juimonen mentioned this pull request Dec 16, 2020
@lgirdwood lgirdwood added this to the ABI-3.17 milestone Feb 3, 2021
@lgirdwood
Copy link
Member

@juimonen I assume this is a "fix" and intended for v1.7 ?

@juimonen
Copy link
Author

juimonen commented Feb 3, 2021

@lgirdwood yes, this is part of the series listed here #3695, I think most of those PR's are merged.

Currently you can't play multiple simultaneous streams at the same time
into mux. Fix this by copying the trigger and reset mechanism from audio
mixer.

Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
@juimonen
Copy link
Author

juimonen commented Feb 3, 2021

@lgirdwood changed the return value in reset walk from 1 to PPL_STATUS_PATH_STOP

@juimonen
Copy link
Author

juimonen commented Feb 4, 2021

@lgirdwood BSW_CYN_MAX98090 test failing should not be related to this, AFAIK it is not using mux in topology

@lgirdwood lgirdwood merged commit 9d41d63 into thesofproject:master Feb 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants