[RFC] Make codec adapter a stand in layer #3881
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cujomalainey
requested review from
bzhg,
dbaluta,
johnylin76,
lgirdwood,
mrajwa and
plbossart
cujomalainey
added
codec
dbaluta
reviewed
Mar 2, 2021
Collaborator
There was a problem hiding this comment.
Ok, I see where this is going. So, now we also need to modify codec_adapter_new to accommodate for the 3rd parameter. This is the way we tell the generic codec adapter which specific ops implementation to use.
Contributor
Author
There was a problem hiding this comment.
yes, and we can add another hook into the register routine to register the codec to a codec list which the multiplexer can pull from
In order to act as a stand in layer for codecs going forward we need to not log using our comp_driver as that will be removed in the future. Instead we need to log using the context of comp_dev. This commit also reduces the verbosity of a lot of the traces and increases a few. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
not sure why this was added. There are very few cases where a static declaration in a header makes sense but this does not appear to be one of them. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
This commit strips the codec adapter as it is more of a library/layer for codecs to simplify their interface against rather than a component in and of itself. This gives each codec its own UUID solving the ID problem while opening an opertunity to register codecs directly for future multiplexing capabilities. Signed-off-by: Curtis Malainey <cujomalainey@chromium.org>
lgirdwood
approved these changes
Mar 20, 2021
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@cujomalainey fwiw, I'm working in this area too and so will @ranj063 , lets have a sync up offline so we dont all do the same work.
Contributor
Author
|
@lgirdwood agreed feel free to put something calendar and I will do my best to make room, mornings are usually the easiest for me though. I'm am stuck debugging this gem of an error though (im dumping pre processor output im so confused) |
Member
|
@cujomalainey might be worth running the pre-processor only on that file and see the output if you think it's macro related. |
Member
|
@cujomalainey thanks, yes, will schedule something next week with @ranj063 too. |
Contributor
Author
Yep already doing that. Hopefully will have an answer soon. |
Collaborator
|
Please resubmit with "main" as PR base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is tackling the change of making codecs their own UUID rather than a sub id. Changes will come in gradually, but I wanted to get early feedback. Will add more stakeholders as larger changes come in.