Skip to content

Conversation

@marc-hb
Copy link
Collaborator

@marc-hb marc-hb commented Mar 23, 2021

There was no [MAIN_]DEPENDS on the .m4 source file, so changes were not
triggering any rebuild.

Signed-off-by: Marc Herbert marc.herbert@intel.com

There was no [MAIN_]DEPENDS on the .m4 source file, so changes were not
triggering any rebuild.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb
Copy link
Collaborator Author

marc-hb commented Mar 23, 2021

The checkpatch WARNING: Misplaced SPDX-License-Identifier tag is a bug in checkpatch, it's triggered every time a code change is too close to the top of the file.

https://travis-ci.org/github/thesofproject/sof/builds/764043617 is the usual docker rate limit

https://sof-ci.01.org/sofpr/PR3945/build8445/devicetest/?model=CML_HEL_RT5682&testcase=check-suspend-resume-5 is the usual TIMEOUT

@marc-hb marc-hb marked this pull request as ready for review March 23, 2021 05:16
@marc-hb marc-hb requested a review from ranj063 as a code owner March 23, 2021 05:16
@marc-hb marc-hb requested a review from paulstelian97 March 23, 2021 05:16
@lgirdwood
Copy link
Member

Try CI again, this should not break tests.

@lgirdwood
Copy link
Member

SOFCI TEST

@marc-hb
Copy link
Collaborator Author

marc-hb commented Mar 23, 2021

https://sof-ci.01.org/sof-pr-viewer/#/build/PR3945/build6195635 has only TestGenericProcessorCompMultiCorePlb48000Hz32b32b4ch failing like this:

07:31:36.167        SNR value is smaller than acceptable value (80.00) on channel 0: 0.16

07:31:36.167       Wave verification failed on channel 1
07:31:40.853        SNR value is smaller than acceptable value (80.00) on channel 0: 1.71

07:31:40.853       Wave verification failed on channel 2
07:31:45.508        SNR value is smaller than acceptable value (80.00) on channel 0: -0.98

07:31:45.508       Wave verification failed on channel 3
07:31:51.038        SNR value is smaller than acceptable value (80.00) on channel 0: 0.80

Every other test is green. Can't be related to this.

https://sof-ci.01.org/sofpr/PR3945/build8452/devicetest/ is amazingly all green

@marc-hb marc-hb requested a review from lyakh March 23, 2021 16:30
@lgirdwood
Copy link
Member

@zrombel can you comment on the internal CI, it looks unrelated.
@marc-hb I've disabled Travis now since its going away and GH actions are now doing the same thing.

@zrombel
Copy link

zrombel commented Mar 24, 2021

Error is unrelated. I will check this test stability with master top.

@lgirdwood
Copy link
Member

@zrombel thanks - let us know when we can merge.

@zrombel
Copy link

zrombel commented Mar 26, 2021

PR is good to merge.

@lgirdwood lgirdwood merged commit 7c08aab into thesofproject:master Mar 26, 2021
@marc-hb marc-hb deleted the incremental-topo-build branch March 30, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants