Skip to content

scheduler: guard against subdivision underflow on domain clear #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Apr 26, 2021
Merged

scheduler: guard against subdivision underflow on domain clear #4088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/schedule/ll_schedule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,9 +331,11 @@ static void schedule_ll_domain_clear(struct ll_schedule_data *sch,
if (count == 1) {
sch->domain->registered[cpu_get_id()] = false;

count = atomic_sub(&sch->domain->num_clients, 1);
if (count == 1)
domain_clear(sch->domain);
if (atomic_read(&sch->domain->num_clients)) {
count = atomic_sub(&sch->domain->num_clients, 1);
Comment on lines +334 to +335
Copy link
Contributor

@jgunn0262 jgunn0262 Apr 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if num_clients changes here between reading and subtracting. @lgirdwood @plbossart what do you think ?

Copy link
Contributor

@keyonjie keyonjie Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if num_clients changes here between reading and subtracting. @lgirdwood @plbossart what do you think ?

We hold the domain->lock during these checks so that should not happen.

BTW, we are kind of mess in this client/task management, I am working on refining them, please see the PR here: #4089

Copy link
Member

@lgirdwood lgirdwood Apr 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, this is fine with the locks held.

if (count == 1)
domain_clear(sch->domain);
}
}

tr_info(&ll_tr, "num_tasks %d total_num_tasks %d",
Expand Down