audio: fix igo_nr wrapper code issues. #4152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuyuntsuo
requested review from
a team,
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
dbaluta
reviewed
May 7, 2021
src/audio/igo_nr/igo_nr.c
Outdated
Collaborator
There was a problem hiding this comment.
Please add one patch per type of issues fixed.
Contributor
Author
There was a problem hiding this comment.
Sure. Just split it to four commits.
Moved struct IGO_PARAMS from igo_nr.c to igo_nr.h since sof_igo_nr_config needs it. Signed-off-by: fy.tsuo <fy.tsuo@intelli-go.com>
The NULL initialization of cd is not necessary. Signed-off-by: fy.tsuo <fy.tsuo@intelli-go.com>
ENUM handlers have been removed in igo_nr_cmd_get_value and igo_nr_cmd_set_value. Signed-off-by: fy.tsuo <fy.tsuo@intelli-go.com>
dbaluta
approved these changes
May 7, 2021
ranj063
reviewed
May 7, 2021
cujomalainey
reviewed
May 7, 2021
A new line is missing after variable declaration. Signed-off-by: fy.tsuo <fy.tsuo@intelli-go.com>
Added legal license file for igo_nr feature. Signed-off-by: fy.tsuo <fy.tsuo@intelli-go.com>
jgunn0262
approved these changes
May 10, 2021
lgirdwood
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolved the issues in #4017 and added license file.
(L223: igo_nr.c)igo_nr_cmd_get_valueandigo_nr_cmd_set_valuestruct IGO_PARAMSfromigo_nr.ctoigo_nr.hsincesof_igo_nr_configneeds it.Signed-off-by: fy.tsuo fy.tsuo@intelli-go.com