Skip to content

Conversation

@dbaluta
Copy link
Collaborator

@dbaluta dbaluta commented May 11, 2021

Without this patch codec adapter submenu is displayed after IGO NR
component resulting in something like this:

[*] Codec adapter
[*] IGO NR components
  Codec adapter codecs

After this patch is applied the display will be as expected:

[*] Codec adapter
  Codec adapter codecs
[*] IGO NR components

Signed-off-by: Daniel Baluta daniel.baluta@nxp.com

@dbaluta
Copy link
Collaborator Author

dbaluta commented May 11, 2021

SOFCI TEST

@lgirdwood
Copy link
Member

@dbaluta can you check the CI, for some reason this is breaking the Zephyr build

@dbaluta
Copy link
Collaborator Author

dbaluta commented May 11, 2021

@lgirdwood Looks like zephyr build fails because of some sort of network issue:

 Reading package lists...
E: Failed to fetch http://apt.llvm.org/focal/dists/llvm-toolchain-focal-12/main/binary-amd64/Packages  File has unexpected size (9435 != 9432). Mirror sync in progress? [IP: 151.101.250.49 443]
E: Some index files failed to download. They have been ignored, or old ones used instead.

@zrombel @marc-hb any idea?

@marc-hb
Copy link
Collaborator

marc-hb commented May 11, 2021

Looks like zephyr build fails because of some sort of network issue

https://github.com/thesofproject/sof/pull/4167/checks?check_run_id=2554833340 looks like a temporary llvm.org glitch. Can you do an empty git commit --amend and force push?

For the record everything else is green including https://sof-ci.01.org/sofpr/PR4167/build9001/devicetest and https://sof-ci.01.org/sof-pr-viewer/#/build/PR4167/build6419971

Without this patch codec adapter submenu is displayed after IGO NR
component resulting in something like this:

[*] Codec adapter
[*] IGO NR components
  Codec adapter codecs

After this patch is applied the display will be as expected:

[*] Codec adapter
  Codec adapter codecs
[*] IGO NR components

Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
@dbaluta
Copy link
Collaborator Author

dbaluta commented May 12, 2021

checkpatch.pl warning is a false positive:

 WARNING: 'rsource' may be misspelled - perhaps 'resource'?
#32: FILE: src/audio/Kconfig:347:
+rsource "codec_adapter/Kconfig"

@dbaluta dbaluta added this to the v1.8 milestone May 12, 2021
@lgirdwood lgirdwood merged commit 8c722f0 into thesofproject:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants