panic: add comments, especially link to dump corruption bug #1346 #4401
+34
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#1346 Zero functional change. These comments would have saved me at least a day. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This was referenced Jun 25, 2021
Collaborator
Author
|
Checkpatch asks me to update the ABI because I added some whitespace in the wrong .h file. No other checkpatch warning. The alsabat failure in https://sof-ci.01.org/sofpr/PR4401/build9486/devicetest/?model=BYT_MB_NOCODEC&testcase=check-alsabat-headset-playback can't possibly be caused by this (and it's getting old) Everything else in that run is green. |
marc-hb
requested review from
akloniex,
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
marc-hb
requested review from
abonislawski,
andyross,
keyonjie,
kv2019i,
lyakh and
paulstelian97
paulstelian97
approved these changes
Jun 25, 2021
lgirdwood
approved these changes
Jun 25, 2021
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Fwiw, the ABI between GCC and XCC is slightly different wrt calling convention and registers windows hence there are some incompatibilities with some of the dump data.
Member
|
Alsabat test local playback from BYT failed CI test is fine and it's unrelated anyway to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zero functional change.
These comments would have saved me at least a day.
Signed-off-by: Marc Herbert marc.herbert@intel.com