-
Notifications
You must be signed in to change notification settings - Fork 349
[TEST] decompose "trace: move CONFIG_TRACEM implementation up a couple levels" #4566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 57ee04f. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This reverts commit 0def905. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
First part of trace: move CONFIG_TRACEM implementation up a couple levels Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
third part of trace: move CONFIG_TRACEM implementation up a couple levels Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
And no joy without the third commit, so now the only hypothesis is the use of va_args that might be problematic? |
|
Tried va_copy but it didn't work, see #4558 (comment) |
Could be - I'm seeing different trace output between GCC and XCC on #4566 based on latest dmesg. |
|
I also get a fail on device hw:0,4 with the first patch that changes the va_args. I will redo the test since this is very surprising. |
|
@plbossart fwiw, I think the va_ code is all in libgcc, so is compiler dependent - I would bet that the Cadence XCC version is optimized for xtensa. The other thing is we seem to be getting more trace messages coming in GCC mode, meaning there is more data (maybe due to va_list parsing ??) |
|
I can confirm that the commit using va_args is enough to fail this test. At this point I would recommend a revert and redo. It's rather unlikely that we are going to figure this one out (edit: in the next hours/days). @ranj063 @lgirdwood any objection? |
|
Revert added in #4573 |
DO NOT MERGE
This is just a split in 3 of @marc-hb 's changes. I believe the changes impacting suspend-resume are in the last patch.
@ranj063 can you try this on CML_HELIOS? I will try on CML_SDW.