-
Notifications
You must be signed in to change notification settings - Fork 349
Revert all patches affecting CML #4578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 57ee04f. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This reverts commit 0def905. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This reverts commit 9a7a5ce. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
|
@ranj063 @lgirdwood See CI results, all green without having to go through hoops... |
|
@plbossart could you have a look at my comments in #4560 ? |
I did look and I see nothing specific for Helios speakers. There's a straightforward path PCM-BUF-PGA-BUF-SSP. |
@plbossart I don't necessarily object reverting. I agree that fixing this properly will take some time. But no, it isn't about the path, it isn't the whole pipeline that takes that long. It's just the time that |
|
@lyakh we can use the UpExtreme in nocodec mode to see if the problem is really on the SOC side. The SSP usage looks the same as everywhere else. I checked with @ranj063 and she has no objection to the revert, let's merge this, run a bunch of stress test this week-end and see next week how to handle these two trace and xrun issues. |
This reverts commit 9fadef7. After multiple trials on a CometLake SoundWire device, this revert to bring the trace back to what it was seems to be the only solution, the suggested PR thesofproject/linux#3166 does not help on this SoundWire device. We had similar issues with SD offset timeouts and a similar revert with thesofproject#4578 at the end of July, there's something that we are missing on what the trace does and how it impacts the DMA handling. BugLink: thesofproject#4779 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This reverts commit 9fadef7. After multiple trials on a CometLake SoundWire device, this revert to bring the trace back to what it was seems to be the only solution, the suggested PR thesofproject/linux#3166 does not help on this SoundWire device. We had similar issues with SD offset timeouts and a similar revert with #4578 at the end of July, there's something that we are missing on what the trace does and how it impacts the DMA handling. BugLink: #4779 Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
It makes no sense to continue if we have two problems impacting the same platform.