Skip to content

Conversation

@plbossart
Copy link
Member

It makes no sense to continue if we have two problems impacting the same platform.

This reverts commit 57ee04f.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This reverts commit 0def905.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
This reverts commit 9a7a5ce.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
Copy link
Member Author

@ranj063 @lgirdwood See CI results, all green without having to go through hoops...

@lyakh
Copy link
Collaborator

lyakh commented Jul 30, 2021

@plbossart could you have a look at my comments in #4560 ?

@plbossart
Copy link
Member Author

@plbossart could you have a look at my comments in #4560 ?

I did look and I see nothing specific for Helios speakers. There's a straightforward path PCM-BUF-PGA-BUF-SSP.
That's why I recommend a revert, I really don't see how we might solve this in the short-term.

@lyakh
Copy link
Collaborator

lyakh commented Jul 30, 2021

@plbossart could you have a look at my comments in #4560 ?

I did look and I see nothing specific for Helios speakers. There's a straightforward path PCM-BUF-PGA-BUF-SSP.
That's why I recommend a revert, I really don't see how we might solve this in the short-term.

@plbossart I don't necessarily object reverting. I agree that fixing this properly will take some time. But no, it isn't about the path, it isn't the whole pipeline that takes that long. It's just the time that dai_trigger() takes on Helios. And I compared that time to UP2 (it's also I2S, right?) and it's ~100us there - a factor of 100 faster. I hoped that someone could tell me what exactly takes that much time there (polling for some initialisation or whatever), but if noone knows that off the top of their head, we'll just have to profile that.

@plbossart
Copy link
Member Author

@lyakh we can use the UpExtreme in nocodec mode to see if the problem is really on the SOC side. The SSP usage looks the same as everywhere else.

I checked with @ranj063 and she has no objection to the revert, let's merge this, run a bunch of stress test this week-end and see next week how to handle these two trace and xrun issues.

@plbossart plbossart merged commit 6daab99 into thesofproject:main Jul 30, 2021
@marc-hb marc-hb mentioned this pull request Sep 15, 2021
plbossart added a commit to plbossart/sof that referenced this pull request Sep 20, 2021
This reverts commit 9fadef7.

After multiple trials on a CometLake SoundWire device, this revert to
bring the trace back to what it was seems to be the only solution, the
suggested PR thesofproject/linux#3166 does not
help on this SoundWire device.

We had similar issues with SD offset timeouts and a similar revert
with thesofproject#4578 at the end of
July, there's something that we are missing on what the trace does and
how it impacts the DMA handling.

BugLink: thesofproject#4779
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
lgirdwood pushed a commit that referenced this pull request Sep 21, 2021
This reverts commit 9fadef7.

After multiple trials on a CometLake SoundWire device, this revert to
bring the trace back to what it was seems to be the only solution, the
suggested PR thesofproject/linux#3166 does not
help on this SoundWire device.

We had similar issues with SD offset timeouts and a similar revert
with #4578 at the end of
July, there's something that we are missing on what the trace does and
how it impacts the DMA handling.

BugLink: #4779
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants