Skip to content

fix ipc handler list uninit bug #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Jul 4, 2018
Merged

fix ipc handler list uninit bug #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/ipc/handler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ static inline struct sof_ipc_hdr *mailbox_validate(void)
return hdr;
}

#ifdef CONFIG_HOST_PTABLE
/* check if a pipeline is hostless when walking downstream */
static bool is_hostless_downstream(struct comp_dev *current)
{
Expand Down Expand Up @@ -151,6 +152,7 @@ static bool is_hostless_upstream(struct comp_dev *current)

return true;
}
#endif

/*
* Stream IPC Operations.
Expand Down Expand Up @@ -200,16 +202,16 @@ static int ipc_stream_pcm_params(uint32_t stream)
cd = pcm_dev->cd;
cd->params = pcm_params->params;

#ifdef CONFIG_HOST_PTABLE
list_init(&elem_list);

/*
* walk in both directions to check if the pipeline is hostless
* skip page table set up if it is
*/
if (is_hostless_downstream(cd) && is_hostless_upstream(cd))
goto pipe_params;

#ifdef CONFIG_HOST_PTABLE
list_init(&elem_list);

/* use DMA to read in compressed page table ringbuffer from host */
err = ipc_get_page_descriptors(iipc->dmac, iipc->page_table,
&pcm_params->params.buffer);
Expand Down Expand Up @@ -242,9 +244,9 @@ static int ipc_stream_pcm_params(uint32_t stream)
list_item_del(&elem->list);
rfree(elem);
}
#endif

pipe_params:
#endif

/* configure pipeline audio params */
err = pipeline_params(pcm_dev->cd->pipeline, pcm_dev->cd, pcm_params);
Expand Down