Skip to content

Conversation

@keyonjie
Copy link
Contributor

Minor incremental fixes for the merged PR: "the Heap refinement Part 2 -- make full use of HPSRAM in buffer zone
#4735"

@lgirdwood
Copy link
Member

CI seems stuck - restart.

@lgirdwood
Copy link
Member

SOFCI TEST

@lgirdwood
Copy link
Member

@keyonjie can you force push again, it seem CI still pending.

@lgirdwood
Copy link
Member

Looks like a network issue on CML test, plus BYT is dead. Redo CI.

@lgirdwood
Copy link
Member

SOFCI TEST

@keyonjie keyonjie force-pushed the main branch 2 times, most recently from 67b0326 to 7f102a9 Compare September 18, 2021 00:20
@lgirdwood
Copy link
Member

CI stuck. restart it.

@lgirdwood
Copy link
Member

SOFCI TEST

@lgirdwood
Copy link
Member

@kkarask @wszypelt it looks like CI codecheck is getting stuck here ? Are we good to merge ?

@kkarask
Copy link

kkarask commented Sep 21, 2021

@lgirdwood Unfortunately, Unit tests failed on APL:

12:27:37,503 INFO - 47: # ok - tests
12:27:37,513 INFO - 46/47 Test #47: fft .............................. Passed 5.01 sec
13:09:50,869 INFO - Terminating launched command gracefully...
13:09:50,882 INFO - Sending output files...
13:09:51,589 INFO - Executing post-execute action...
13:09:51,589 ERROR - Step 'master>SOF_FW PARALLEL>UNIT_TESTS>PLATFORM UNIT TESTS?PlatformName=APL>UT CMAKE>CMAKE UT' is failed.

@keyonjie Could you check your change, because it failed only on APL?

@kkarask
Copy link

kkarask commented Sep 21, 2021

Something wrong with publishing error status. We will fix it, but it can take some time, sorry:)

The buffer zone will not occupy more than half of the HP SRAM, decrease
the HEAP_BUFFER_COUNT_MAX which can help save about 5KB for us.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
We have limited buffer zone which can't afford as big as 200KB+
allocation request on platforms like APL, remove the case.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
Add a comment about the HP_SRAM_SIZE calculation.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@keyonjie
Copy link
Contributor Author

keyonjie commented Sep 22, 2021

@keyonjie Could you check your change, because it failed only on APL?

Thanks for the info @kkarask I fixed that in the PR #4747 but forgot adding it to here.

Now it should already be fixed with the latest update.

@lgirdwood
Copy link
Member

BYT ALSA bat sounds correct with no obvious clipping, https://sof-ci.01.org/sofpr/PR4753/build10422/devicetest/?model=BYT_MB_NOCODEC&testcase=multiple-pause-resume-5 looks like a logger issue.

@lgirdwood lgirdwood merged commit d2bcb65 into thesofproject:main Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants