edf_schedule: clear interrupt before enabling #5026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resuming after a suspend, sometimes a spurious EDF interrupt arrives, causing panic in assert() in edf_scheduler_run(). Clear the interrupt before enabling it to avoid that. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lgirdwood
reviewed
Nov 24, 2021
| return edf_sch->irq; | ||
|
|
||
| interrupt_mask(edf_sch->irq, cpu_get_id()); | ||
| interrupt_unmask(edf_sch->irq, cpu_get_id()); |
Member
Collaborator
Author
There was a problem hiding this comment.
@lgirdwood of course it isn't optimal and yes, interrupt_clear() would be the right function to call, but currently it only clears DSP "native" interrupts, and this is a level-2 interrupt. Let's test if this helps, if it does, we can try to extend interrupt_clear() to also work on "level interrupts."
Contributor
Contributor
There was a problem hiding this comment.
Thanks for the test. @lyakh @lgirdwood I would suggest to make the #4874 as hotfix for 1.9 and keep main unchanged as root causing the #4538 could be very time consuming.
Collaborator
|
Can one of the admins verify this patch? |
Member
Contributor
|
@libinyang told me that this didn't help anything, so I would suggest keeping it intact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When resuming after a suspend, sometimes a spurious EDF interrupt arrives, causing panic in assert() in edf_scheduler_run(). Clear the interrupt before enabling it to avoid that.