math : Add square root function using a lookup table #5034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
reviewed
Nov 26, 2021
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
6 times, most recently
from
fc0748a to
59bfe17
Compare
ShriramShastry
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
ShriramShastry
requested review from
cujomalainey,
johnylin76,
juimonen,
keyonjie,
mwasko and
singalsu
singalsu
reviewed
Nov 29, 2021
singalsu
reviewed
Nov 29, 2021
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
3 times, most recently
from
4054b3e to
2b3433e
Compare
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
from
2b3433e to
89885a1
Compare
singalsu
reviewed
Nov 30, 2021
singalsu
reviewed
Nov 30, 2021
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
from
89885a1 to
09b21a9
Compare
singalsu
approved these changes
Dec 1, 2021
Collaborator
singalsu
left a comment
singalsu
left a comment
There was a problem hiding this comment.
You have one not needed type cast (double)y in cmocka function. Otherwise OK so approve. Thanks!
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
from
54e2e4f to
42ada44
Compare
lgirdwood
reviewed
Dec 1, 2021
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Just one minor correction needed.
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
from
42ada44 to
7c5fd40
Compare
lgirdwood
approved these changes
Dec 1, 2021
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
2 times, most recently
from
dbf0b81 to
9814180
Compare
Collaborator
|
More C99 comments... can we finally turn off this warning? EDIT: submitted in #5046 |
cujomalainey
suggested changes
Dec 1, 2021
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
3 times, most recently
from
68db25d to
ca8fc26
Compare
marc-hb
reviewed
Dec 2, 2021
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
from
ca8fc26 to
613fcdb
Compare
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
3 times, most recently
from
fe4fcb6 to
a3f41ce
Compare
marc-hb
reviewed
Dec 15, 2021
Collaborator
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Some minor style issues
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
from
a3f41ce to
879b571
Compare
Member
|
@cujomalainey are you happy to for this to merge ? |
cujomalainey
approved these changes
Dec 16, 2021
Contributor
cujomalainey
left a comment
cujomalainey
left a comment
There was a problem hiding this comment.
one minor comment complaint but otherwise LGTM
src/math/sqrt_int16.c
Outdated
Contributor
There was a problem hiding this comment.
nit: this comment seems out of place
Contributor
Author
There was a problem hiding this comment.
I remove it.
fix point math square function having positive number y as input and return the positive number x multiplied by itself (squared) Signed-off-by: Shriram Shastry <malladi.sastry@intel.com>
ShriramShastry
force-pushed
the
shastry_sqrt_dev
branch
from
879b571 to
1212e15
Compare
Contributor
|
Once CI returns I think we can merge |
Collaborator
|
@cujomalainey @lgirdwood CI issues look unrelated. |
Collaborator
|
Three approvals, would be nice to get this merged because my PR #4826 can't pass CI without this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix point math square function having positive number y as input and
return the positive number x multiplied by itself (squared)
Signed-off-by: MalladiSastry shastry@mherber2-ub20.ostc.intel.com