Skip to content

Conversation

@wenliangwu
Copy link
Contributor

This commit adds mt8195 into the supported platforms in qemu-check.sh.
Please help review it.

Enable check to mt8195 platform of QEMU boot test.

Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
@wenliangwu wenliangwu requested a review from marc-hb as a code owner January 27, 2022 02:09
@sofci
Copy link
Collaborator

sofci commented Jan 27, 2022

Can one of the admins verify this patch?

reply test this please to run this test once

@gkbldcig
Copy link
Collaborator

Can one of the admins verify this patch?

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 27, 2022

test this please

@marc-hb marc-hb requested a review from dbaluta January 27, 2022 02:29
@marc-hb
Copy link
Collaborator

marc-hb commented Jan 27, 2022

Note the qemu branch is still blocked by qemu regression #4186

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 27, 2022

Eventually this should be added to the matrix in .github/workflows/pull-request.yml too otherwise it will "bitrot"

@wenliangwu wenliangwu closed this Jan 27, 2022
@wenliangwu wenliangwu reopened this Jan 27, 2022
@wenliangwu
Copy link
Contributor Author

@marc-hb Should I update ".github/workflows/pull-request.yml" too, or you will help update it when #4186 is fixed.

@marc-hb
Copy link
Collaborator

marc-hb commented Jan 27, 2022

Add now if it works, later if not yet.

@lgirdwood
Copy link
Member

@wenliangwu pls check your email, I've sent invite so that CI will run automatically from now on (starts at your next PR)

@wenliangwu
Copy link
Contributor Author

wenliangwu commented Jan 28, 2022

@wenliangwu pls check your email, I've sent invite so that CI will run automatically from now on (starts at your next PR)

Done. Thanks for your invite.

Add now if it works, later if not yet.

@marc-hb
I think it can't work now, because mt8195 isn't included in the qemu docker image.
Do you suggest me put mt8195 to gcc-build-only list first?

On the other hand, qemu docker image seems to be built from sof-v4.2, but I submitted qemu patch for mt8195 to sof-v5.2.0 (thesofproject/qemu@b85c079).
Should I also upload the patch to sof-v4.2?
Thanks.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wenliangwu This patch is fine, but do we still have dependencies for merging ?

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 7, 2022

When invoked without any argument the script iterates on all SUPPORTED_PLATFORMS. So we can't really merge this before it actually works.

@wenliangwu there is also this possibility: SCRAP

EDIT: sorry I meant c7fc085

@wenliangwu
Copy link
Contributor Author

@lgirdwood As marc-hb mentioned, this is still blocked by #4186.

@marc-hb Do you mean I can still add mt8195 to SUPPORTED_PLATFORM; on the other hand, add DEFAULT_PLATFORM excluding mt8195 to keep the default behavior?

@marc-hb
Copy link
Collaborator

marc-hb commented Jul 11, 2022

add DEFAULT_PLATFORM excluding mt8195 to keep the default behavior?

Yes this is what I meant exactly. Copy the feature that makes a difference between SUPPORTED_ vs DEFAULT_ from the other scripts. Copy that feature only if you think it will make your life easier, otherwise don't bother.

@kv2019i
Copy link
Collaborator

kv2019i commented Apr 24, 2023

Converting to draft, no activity in 3 months.

@kv2019i kv2019i marked this pull request as draft April 24, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants