-
Notifications
You must be signed in to change notification settings - Fork 349
scripts/qemu-check.sh: Add qemu check for mt8195 platform #5274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Enable check to mt8195 platform of QEMU boot test. Signed-off-by: Trevor Wu <trevor.wu@mediatek.com>
|
Can one of the admins verify this patch?
|
|
Can one of the admins verify this patch? |
|
test this please |
|
Note the qemu branch is still blocked by qemu regression #4186 |
|
Eventually this should be added to the matrix in |
|
Add now if it works, later if not yet. |
|
@wenliangwu pls check your email, I've sent invite so that CI will run automatically from now on (starts at your next PR) |
Done. Thanks for your invite.
@marc-hb On the other hand, qemu docker image seems to be built from sof-v4.2, but I submitted qemu patch for mt8195 to sof-v5.2.0 (thesofproject/qemu@b85c079). |
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wenliangwu This patch is fine, but do we still have dependencies for merging ?
|
When invoked without any argument the script iterates on all SUPPORTED_PLATFORMS. So we can't really merge this before it actually works. @wenliangwu there is also this possibility: SCRAP EDIT: sorry I meant c7fc085 |
|
@lgirdwood As marc-hb mentioned, this is still blocked by #4186. @marc-hb Do you mean I can still add mt8195 to SUPPORTED_PLATFORM; on the other hand, add DEFAULT_PLATFORM excluding mt8195 to keep the default behavior? |
Yes this is what I meant exactly. Copy the feature that makes a difference between SUPPORTED_ vs DEFAULT_ from the other scripts. Copy that feature only if you think it will make your life easier, otherwise don't bother. |
|
Converting to draft, no activity in 3 months. |
This commit adds mt8195 into the supported platforms in qemu-check.sh.
Please help review it.