Skip to content

Conversation

@abonislawski
Copy link
Member

Up Down Mixer module
Conversions supported:
Up/Downmixing for stereo output:
1, 2, 2.1, 3.0, 3.1, Quatro, 4.0, 5.0, 5.1, 7.1 -> 2
Upmixing for multichannel output:
1, 2 -> 5.1
2 -> 7.1
Downmixing for mono output:
4.0, Quatro, 3.1,
2 -> 1
At initial release only hifi3 version is supported.

Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com
Signed-off-by: Adrian Bonislawski adrian.bonislawski@intel.com

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove all the assert() but otherwise minor stuff. The frag API is slower than the new method that @singalsu is using and we should update.

@dbaluta
Copy link
Collaborator

dbaluta commented Jan 31, 2022

@abonislawski Question: in the case of upmixing for example 2 -> 5.1 does it mean that your DAI (SSP in Intel case) supports 6 channels right?

How is this configured?

@lgirdwood
Copy link
Member

@abonislawski Question: in the case of upmixing for example 2 -> 5.1 does it mean that your DAI (SSP in Intel case) supports 6 channels right?

How is this configured?

It's for HDMI and can be configured in the topology e.g user opens a stereo stream and topology defines the HDMI output at 5.1 with the updwmix module in the pipe.

@lgirdwood
Copy link
Member

@abonislawski pls see #5300 for efficient copy() updates usage (i.e non usage of frag API). Can be mostly copied here.

Copy link
Collaborator

@singalsu singalsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write this without write frag function. It performs horribly slow.

@abonislawski abonislawski force-pushed the updwmix_ipc4_upstream branch from 6d4bf01 to b13ddc5 Compare February 4, 2022 16:43
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pass the error up the stack, but otherwise good.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to remove the xtensa Cmake change and we are good.

@abonislawski abonislawski force-pushed the updwmix_ipc4_upstream branch from 4afc2e5 to 89eaced Compare February 9, 2022 10:36
@lgirdwood
Copy link
Member

@abonislawski looks like doxygen is reporting a single issue in CI.

@abonislawski abonislawski force-pushed the updwmix_ipc4_upstream branch from 89eaced to ad0c007 Compare February 9, 2022 12:47
Up Down Mixer module
Conversions supported:
Up/Downmixing for stereo output:
	1, 2, 2.1, 3.0, 3.1, Quatro, 4.0, 5.0, 5.1, 7.1 -> 2
Upmixing for multichannel output:
	1, 2 -> 5.1
	2 -> 7.1
Downmixing for mono output:
	4.0, Quatro, 3.1,
	2 -> 1
At initial release only hifi3 version is supported.

Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
@abonislawski
Copy link
Member Author

@lgirdwood doxygen and a few spelling errors fixed

@lgirdwood lgirdwood merged commit 33ec780 into thesofproject:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants