-
Notifications
You must be signed in to change notification settings - Fork 349
ipc4: add updwmix module support #5287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipc4: add updwmix module support #5287
Conversation
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove all the assert() but otherwise minor stuff. The frag API is slower than the new method that @singalsu is using and we should update.
|
@abonislawski Question: in the case of upmixing for example 2 -> 5.1 does it mean that your DAI (SSP in Intel case) supports 6 channels right? How is this configured? |
It's for HDMI and can be configured in the topology e.g user opens a stereo stream and topology defines the HDMI output at 5.1 with the updwmix module in the pipe. |
|
@abonislawski pls see #5300 for efficient copy() updates usage (i.e non usage of frag API). Can be mostly copied here. |
singalsu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please write this without write frag function. It performs horribly slow.
6d4bf01 to
b13ddc5
Compare
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to pass the error up the stack, but otherwise good.
b13ddc5 to
4afc2e5
Compare
lgirdwood
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to remove the xtensa Cmake change and we are good.
4afc2e5 to
89eaced
Compare
|
@abonislawski looks like doxygen is reporting a single issue in CI. |
89eaced to
ad0c007
Compare
Up Down Mixer module Conversions supported: Up/Downmixing for stereo output: 1, 2, 2.1, 3.0, 3.1, Quatro, 4.0, 5.0, 5.1, 7.1 -> 2 Upmixing for multichannel output: 1, 2 -> 5.1 2 -> 7.1 Downmixing for mono output: 4.0, Quatro, 3.1, 2 -> 1 At initial release only hifi3 version is supported. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com> Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
|
@lgirdwood doxygen and a few spelling errors fixed |
Up Down Mixer module
Conversions supported:
Up/Downmixing for stereo output:
1, 2, 2.1, 3.0, 3.1, Quatro, 4.0, 5.0, 5.1, 7.1 -> 2
Upmixing for multichannel output:
1, 2 -> 5.1
2 -> 7.1
Downmixing for mono output:
4.0, Quatro, 3.1,
2 -> 1
At initial release only hifi3 version is supported.
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com
Signed-off-by: Adrian Bonislawski adrian.bonislawski@intel.com