Audio: EQIIR: Optimize pass-through mode read/write frags #5333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgirdwood
reviewed
Feb 9, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Whats the speed improvement ?
Collaborator
Author
I did this test. In sof-hda-generic-2ch.tplg I can capture 32-32, 32-32, 32-16 conversion modes of IIR. The 32-32 was already handled well by 1:1 stream copy function with 6 MCPS. The 32-16 bits case improved 22.4 MCPS to 6.4 MCPS (-16 MCPS), the 32-24 bits case improved 23.6 MCPS to 6.8 MCPS (-16.8 MCPS). I'll add this to commit text.
|
This patch optimizes the remaining EQ functions eq_iir_s32_s16_pass() and eq_iir_s32_s24_pass() to not use audio stream read/write frag functions. This patch did not change x-x bit case that was already handled efficiently by 1:1 stream copy function with 6 MCPS. The 32-16 bits case improved 22.4 MCPS to 6.4 MCPS (-16 MCPS), the 32-24 bits case improved 23.6 MCPS to 6.8 MCPS (-16.8 MCPS). Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
iir_passthrough_optimize
branch
from
7fac18c to
cc9250b
Compare
singalsu
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
singalsu
commented
Feb 10, 2022
lgirdwood
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch optimizes the remaining EQ functions eq_iir_s32_s16_pass()
and eq_iir_s32_s24_pass() to not use audio stream read/write
frag functions.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com