Skip to content

sof-logger: fail when an invalid address is found in the DMA trace #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marc-hb wants to merge 1 commit into from
Closed

sof-logger: fail when an invalid address is found in the DMA trace #5340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions tools/logger/convert.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,13 +888,14 @@ static int logger_read(void)
global_config->logs_header->data_length) {
/* Finding uninitialized and incomplete log statements in the
* mailbox ring buffer is routine. Take note in both cases but
* report errors only for the DMA trace.
* fail only for the DMA trace.
* ldc_address_OK means we had started processing a valid trace.
*/
if (global_config->trace && ldc_address_OK) {
log_err("log_entry_address %#10x is not in dictionary range!\n",
log_err("log_entry_address %#10x is not in dict. range! Aborting\n",
dma_log.log_entry_address);
fprintf(global_config->out_fd,
"warn: Seeking forward 4 bytes at a time until re-synchronize.\n");
ret = -EPROTO;
break;
}
ldc_address_OK = false;
/* When the address is not correct, move forward by one DWORD (not
Expand Down