xtensa-build-zephyr.py: fix -C option so it can support whitespace #5383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need control to format add_argument(help=...) strings manually too. Zero functional change. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Make it possible to invoke -C multiple times which is required to support whitespace as in: -C=--warn-uninitialized -C '-DEXTRA_FLAGS=-Werror -g0' Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
XiaoyunWu6666,
aiChaoSONG,
fredoh9,
greg-intel and
keqiaozhang
Collaborator
Author
|
https://sof-ci.01.org/sofpr/PR5383/build12069/devicetest/?model=BYT_MB_NOCODEC&testcase=check-kmod-load-unload-after-playback is a recent issue because the kmod-reload test was fixed (it was testing nothing). Additional delay added by thesofproject/sof-test#862 should fix it The TIMEOUT in https://sof-ci.01.org/sofpr/PR5383/build12069/devicetest/?model=CML_SKU0955_HDA&testcase=check-playback-10sec is worrying, there's been a surge of timeouts recently... but it's totally u related to this. |
aborisovich
approved these changes
Feb 18, 2022
Contributor
aborisovich
left a comment
aborisovich
left a comment
There was a problem hiding this comment.
Thanks Marc for the fix, good job 👍
lgirdwood
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits, best reviewed separately
Make it possible to invoke -C multiple times which is required to
support whitespace as in:
Restores feature parity with the shell script.
Note this is not backward compatible (but the whole script was merged only this week)
Signed-off-by: Marc Herbert marc.herbert@intel.com