dma-trace: Preserve logs while dtrace is disabled #5397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the dma-trace is enabled (or re-enabled) the DMA channel is re-initialized, configured. The DMA will start reading data from the local buffer from the start (!!) it can not be configured to start reading from the point it is left off. Because of this, if the dtrace is disabled and re-enabled, the DMA will copy old log entries starting from the beginning of the local buffer. To be able to preserve the logs while the dtrace is disable we need to reset both read and write pointers on the local buffer and when the dtrace is again enabled we can transfer the logs from this point, without misaligned or missed logs. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
lgirdwood
approved these changes
Feb 22, 2022
dbaluta
approved these changes
Feb 22, 2022
Collaborator
|
Revert submitted in #5410 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dma-trace is enabled (or re-enabled) the DMA channel is
re-initialized, configured.
The DMA will start reading data from the local buffer from the start (!!)
it can not be configured to start reading from the point it is left off.
Because of this, if the dtrace is disabled and re-enabled, the DMA will
copy old log entries starting from the beginning of the local buffer.
To be able to preserve the logs while the dtrace is disable we need to
reset both read and write pointers on the local buffer and when the dtrace
is again enabled we can transfer the logs from this point, without
misaligned or missed logs.
Signed-off-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com