Skip to content

dma-trace: Print banners in case of dtrace re-initialization atempt #5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ujfalusi wants to merge 1 commit into from
Closed

dma-trace: Print banners in case of dtrace re-initialization atempt #5416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/trace/dma-trace.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,16 +248,9 @@ static int dma_trace_buffer_init(struct dma_trace_data *d)
uint32_t addr_align;
int err;

/*
* Keep the existing dtrace buffer to avoid memory leak, unlikely to
* happen if host correctly using the dma_trace_disable().
*
* The buffer can not be freed up here as it is likely in use.
* The (re-)initialization will happen in dma_trace_start() when it is
* safe to do (the DMA is stopped)
*/
/* Keep the existing dtrace buffer to avoid memory leak */
if (dma_trace_initialized(d))
return 0;
goto print_banners;

if (!d || !d->dc.dmac) {
mtrace_printf(LOG_LEVEL_ERROR,
Expand Down Expand Up @@ -317,6 +310,7 @@ static int dma_trace_buffer_init(struct dma_trace_data *d)
}
#endif

print_banners:
#ifdef __ZEPHYR__
#define ZEPHYR_VER_OPT " zephyr:" META_QUOTE(BUILD_VERSION)
#else
Expand Down