-
Notifications
You must be signed in to change notification settings - Fork 349
preproc: varargscount: bugfix for tokens starting with '(' not being counted #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preproc: varargscount: bugfix for tokens starting with '(' not being counted #543
Conversation
4e0c843 to
cefa580
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking about removing all whitespaces for this check in the future, as it really doesn't matter whether preprocessor gives us
uint32_t param0 , uint32_t... or
uint32_t param0,uint32_t...
as the compiler doesn't care.
Again, I'd rather not do this in bugfix PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New unit tests:
#define PARENTHESIS_PRE() (1+3)/2
#define PARENTHESIS_POST() 4/(3-1)
...
TEST_HERE_DECLARE(func_name, with_parenthesis_pre, 1, PARENTHESIS_PRE())
TEST_HERE_DECLARE(func_name, with_parenthesis_post, 1,PARENTHESIS_POST())
…g with parenthesis not being counted ; also introduced unit tests to check the issue Signed-off-by: Michal Jerzy Wierzbicki <michalx.wierzbicki@linux.intel.com>
cefa580 to
87dad4a
Compare
|
Great, Travis build for SUE hanged during |
|
@mwierzbix
|
|
@mwierzbix Fwiw, Travis can be restarted if you click on details and the rebuild. |
|
@lgirdwood @xiulipan Thanks :) |
|
Added @slawblauciak for cmocka parts |
…ount_0_for_parenthesis
; also introduced unit tests to check the issue
Signed-off-by: Michal Jerzy Wierzbicki michalx.wierzbicki@linux.intel.com
varargscount is macro META_COUNT_VARARGS_BEFORE_COMPILE
Fix for issue #542