Skip to content

Conversation

@mwierzbix
Copy link
Contributor

; also introduced unit tests to check the issue

Signed-off-by: Michal Jerzy Wierzbicki michalx.wierzbicki@linux.intel.com

varargscount is macro META_COUNT_VARARGS_BEFORE_COMPILE

Fix for issue #542

@mwierzbix mwierzbix force-pushed the debugability-macro-metaprog-bugfix-varargcount_0_for_parenthesis branch from 4e0c843 to cefa580 Compare November 6, 2018 01:18
@mwierzbix mwierzbix added fixed bug Something isn't working as expected and removed fixed labels Nov 6, 2018
@mwierzbix mwierzbix requested a review from lgirdwood November 6, 2018 01:21
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking about removing all whitespaces for this check in the future, as it really doesn't matter whether preprocessor gives us
uint32_t param0 , uint32_t... or
uint32_t param0,uint32_t...
as the compiler doesn't care.

Again, I'd rather not do this in bugfix PR.

Copy link
Contributor Author

@mwierzbix mwierzbix Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New unit tests:

#define PARENTHESIS_PRE()  (1+3)/2
#define PARENTHESIS_POST() 4/(3-1)
...
TEST_HERE_DECLARE(func_name, with_parenthesis_pre,  1, PARENTHESIS_PRE())
TEST_HERE_DECLARE(func_name, with_parenthesis_post, 1,PARENTHESIS_POST())

…g with parenthesis not being counted

; also introduced unit tests to check the issue

Signed-off-by: Michal Jerzy Wierzbicki <michalx.wierzbicki@linux.intel.com>
@mwierzbix mwierzbix force-pushed the debugability-macro-metaprog-bugfix-varargcount_0_for_parenthesis branch from cefa580 to 87dad4a Compare November 6, 2018 01:40
@mwierzbix mwierzbix added the P1 Blocker bugs or important features label Nov 6, 2018
@mwierzbix mwierzbix self-assigned this Nov 6, 2018
@mwierzbix
Copy link
Contributor Author

Great, Travis build for SUE hanged during docker pull (it is, even before attempting to build).
https://travis-ci.org/thesofproject/sof/jobs/451169579
This day cannot get any better it seems.

@xiulipan
Copy link
Contributor

xiulipan commented Nov 6, 2018

@mwierzbix
Do not worry, I will retrigger the build for you.
And I think Travis have some magic word to rebuild the tset.

If you've sent a pull request: You can close the PR then open it again. This will trigger a new build.
https://stackoverflow.com/questions/17606874/trigger-a-travis-ci-rebuild-without-pushing-a-commit

@lgirdwood
Copy link
Member

@mwierzbix Fwiw, Travis can be restarted if you click on details and the rebuild.

@mwierzbix
Copy link
Contributor Author

@lgirdwood @xiulipan Thanks :)
Adding to what you said, you also have to be logged into Travis with your Github account (probably one being contributor to thesofproject) in order to schedule restart.

@lgirdwood
Copy link
Member

Added @slawblauciak for cmocka parts

@lgirdwood lgirdwood merged commit 431711c into thesofproject:master Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected P1 Blocker bugs or important features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants