google_rtc_audio_processing: Add config controls #5488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkoenig
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
cujomalainey
suggested changes
Mar 8, 2022
Contributor
Author
|
Codestyle issue are from an internal header file I want to keep as close as possible to internal code style. |
lkoenig
force-pushed
the
dev/aec_config
branch
2 times, most recently
from
85a0f8e to
07a2881
Compare
lgirdwood
approved these changes
Mar 9, 2022
Contributor
Author
|
@cujomalainey Do you require more change ? |
cujomalainey
approved these changes
Mar 15, 2022
Contributor
|
Checkpatch appears to be complaining about tabs v spaces and some other spacing stuff |
lkoenig
force-pushed
the
dev/aec_config
branch
2 times, most recently
from
1143cf1 to
1eb17d8
Compare
1. Added a byte control to accept Google RTC audio processing
configuration blob
`name='GOOGLE_RTC_PROCESSING10.0 Config'`
Tested using:
sof-ctl -n 48 -t 0 -b -r -s /root/tuning.bin
And verified correct audio processing behaviour on a alderlake board.
Signed-off-by: Ben Zhang <benzh@chromium.org>
Signed-off-by: Lionel Koenig <lionelk@google.com>
Contributor
Author
|
I fixed some of the checkpatch and rebased on top of main. |
cujomalainey
approved these changes
Mar 15, 2022
Contributor
|
Failures are either not relevant or being ignored (checkpatch) as the file is imported |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configuration blob
name='GOOGLE_RTC_PROCESSING10.0 Config'Tested using:
sof-ctl -n 48 -t 0 -b -r -s /root/tuning.bin
And verified correct audio processing behaviour on a alderlake board.
Signed-off-by: Ben Zhang benzh@chromium.org
Signed-off-by: Lionel Koenig lionelk@google.com