Skip to content

Conversation

@chunxu-li
Copy link
Contributor

Hi,
I'm a chromebook project developer at Mediatek and working on SOF audio driver on mt8186.
There are some platform driver that have been verified on mt8186 EVB.

Please let me know if there is any questions.

Thanks.

@sofci
Copy link
Collaborator

sofci commented Mar 9, 2022

Can one of the admins verify this patch?

reply test this please to run this test once

@gkbldcig
Copy link
Collaborator

gkbldcig commented Mar 9, 2022

Can one of the admins verify this patch?

@lgirdwood
Copy link
Member

please test this

@lgirdwood
Copy link
Member

@chunxu-li ignore message above its a CI command.

Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the merge commit.

Add memif data for AFE
Add common and regs header for AFE
Add AFE platform for mt8186 audio/dsp

AFE: the abbreviation for Audio Front End

Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
Add afe-platform compile support for mt8186

Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
@chunxu-li
Copy link
Contributor Author

Done

@lgirdwood
Copy link
Member

@kuanhsuncheng @afq984 good for you ?

@afq984 afq984 requested a review from cujomalainey March 15, 2022 09:10
Copy link
Contributor

@kuanhsuncheng kuanhsuncheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yaochunhung Hi YC, please let us know if you have any comments for this PR? thanks.

Copy link
Contributor

@cujomalainey cujomalainey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go back and check your return types, you are throwing away a lot of return values and I am sure I missed some functions

@cujomalainey cujomalainey requested a review from afq984 March 20, 2022 00:19
Add AFE driver for memif/sinegen
Add afe-dai.c/afe-drv.c/afe-memif.c for AFE common driver

AFE: Audio Front End

The audio front-end essentially consists of voice and audio data paths.

frontend (memory interface):
 UL (uplink for capture)
 DL (downlink for playback)
backend:
 I2S In/Out etc
interconn:
 inter-connection, connect frontends and backends as DSP path

Note:
TEST_SGEN macro define is just for test

Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
compile mt8186 drivers

Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
Add support for dai, dma platform driver.

Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
@chunxu-li chunxu-li requested a review from cujomalainey March 30, 2022 10:03
@cujomalainey cujomalainey requested a review from yaochunhung April 4, 2022 20:27
@cujomalainey
Copy link
Contributor

once I get an update on that last nit I can submit for you if you think its ready

Add platform dai build support
Add platform dai_init

Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
the afe_remove return value is no used, so
change afe_remove return value from int to void

Signed-off-by: Chunxu Li <chunxu.li@mediatek.com>
@cujomalainey cujomalainey merged commit 7b5aa72 into thesofproject:main Apr 5, 2022
@cujomalainey
Copy link
Contributor

@lgirdwood is there an ignore list we can add afe to for the checkpatch script?

@lgirdwood
Copy link
Member

@lgirdwood is there an ignore list we can add afe to for the checkpatch script?

possibly, IIUC the script can be modified if needed.

@cujomalainey
Copy link
Contributor

@lgirdwood is there an ignore list we can add afe to for the checkpatch script?

possibly, IIUC the script can be modified if needed.

Who would know about this? Otherwise its basically impossible to use checkpatch for afe drivers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants