google-rtc-audio: Make AEC reference stereo #5500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkoenig
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
reviewed
Mar 9, 2022
Member
There was a problem hiding this comment.
The frag API is being deprecated by @singalsu as it adds MCPS. Do you want to merge this now and fix the frag API usage later ?
Contributor
Author
There was a problem hiding this comment.
I think we should do that.
I want to get rid of the frag API but I'll have to do that carefully to avoid buffering issue.
The reason the frag API works here is that sometimes the aec_reference has 4 channels, using the frag API allows easily to only use those 2 first ones).
lgirdwood
approved these changes
Mar 10, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@cujomalainey good for you ?
To provide echo cancelling effect while a stereo signal is played out, the RTC Audio processing component required to have both left and right channel as reference. This CL ensure this is the case. Signed-off-by: Lionel Koenig <lionelk@google.com>
cujomalainey
approved these changes
Mar 15, 2022
Contributor
|
CI failure is for rimage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide echo cancelling effect while a stereo signal is played out,
the RTC Audio processing component required to have both left and right
channel as reference.
This CL ensure this is the case.
Signed-off-by: Lionel Koenig lionelk@google.com