xtensa-build-all: add a separate target for JSL #5503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
reviewed
Mar 9, 2022
scripts/xtensa-build-zephyr.sh
Outdated
Collaborator
There was a problem hiding this comment.
Depending on how long the Zephyr PR is going to take, you can add it to SUPPORTED_PLATFORMS right now. This will enable other people to try it now without breaking CI.
Same thing with line 84 in the python script.
kv2019i
requested review from
aborisovich,
keqiaozhang,
lgirdwood,
lyakh and
marc-hb
Collaborator
Author
|
SOFCI TEST |
marc-hb
approved these changes
Mar 11, 2022
scripts/xtensa-build-zephyr.sh
Outdated
Collaborator
There was a problem hiding this comment.
Does this one pass shellcheck? Sometimes it's smart enough to know quotes are not needed, sometimes it's not.
Collaborator
Author
There was a problem hiding this comment.
What's shellcheck? :) I copied the tgl-h check and that fails as well. I'll update.
Collaborator
There was a problem hiding this comment.
What's shellcheck? :)
:-)
The best thing since sliced bread.
The only way to keep shell scripts relatively maintainable and trouble-free.
Use intel_adsp_cavs20_jsl Zephyr board when building for Intel Jasper Lake. BugLink: thesofproject#4539 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
kv2019i
force-pushed
the
topic/fix-jsl-support
branch
from
56d42a9 to
439a0f4
Compare
aborisovich
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-on: zephyrproject-rtos/zephyr#43611
Keeping as draft until the Zephyr PR is merged.
Use intel_adsp_cavs20_jsl Zephyr board when building for
Intel Jasper Lake.
BugLink: #4539
Signed-off-by: Kai Vehmanen kai.vehmanen@linux.intel.com