xtensa-build-zephyr.py: do not git submodule update #5514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The older shell script had a deprecated convenience hack to clone submodules before building rimage but _only if submodules were missing_! While trying to preserve that, the new script changed that to an unconditional git submodule update that can be destructive when submodules are already present. Generally speaking, using git and building must always be two very distinct activities. No one wants the source code to change quietly from one build to the next. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
added
bug
lgirdwood
approved these changes
Mar 10, 2022
Collaborator
Author
|
The ICL-only "Copy build to DUT" failure in https://sof-ci.01.org/sof-pr-viewer/#/build/PR5514/build8789548 is not a build failure (and likely not a Zephyr failure either). @kkarask could you have a look? https://sof-ci.01.org/sof-pr-viewer/#/build/PR5514/build8790636 failed the same again. Same in other PR https://sof-ci.01.org/sof-pr-viewer/#/build/PR5515/build8790824 |
This script is run from an existing SOF repo that is assumed to be fully initialized. Updating existing submodules is a potentially destructive operation. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
changed the title
Collaborator
Author
|
All failures in https://sof-ci.01.org/sofpr/PR5514/build12312/devicetest/ are known, filed and unrelated to this PR |
aborisovich
approved these changes
Mar 11, 2022
Contributor
aborisovich
left a comment
aborisovich
left a comment
There was a problem hiding this comment.
Thank you @marc-hb - this not-needed submodule update gave us integration troubles.
|
Yes, it was platform related issue. Rerun passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: 2 commits now. see commit messages.
The purpose of this convenience script is to get and build zephyr from SOF, it's not to mess with an existing SOF workspace.