xtensa-build-zephyr.py: restore ability to override CI + more catch up with the .sh script #5515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running on a mac crashed with "undefined xtensa_tools_version_postfix", that should not be fatal (there are other toolchains). Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This makes the code more readable and other scripts possibly too. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This restores the performance of the original shell script and makes a big difference in CI. CI clones over and over again whereas developers clone rarely and can run a simple git fetch --unshallow. Don't use --depth 0 to provide more context in the logs and also make it more obvious that this is a shallow clone and not just git log -n 1. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This has been useful to test Zephyr work in progress. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
job/sof_prs/12313 hit some internal cloning issue, restarting. |
Collaborator
Author
|
SOFCI TEST The failures in https://sof-ci.01.org/sofpr/PR5515/build12314/devicetest/ are all known and none of them happened with Zephyr, only with XTOS |
dcpleung
approved these changes
Mar 11, 2022
aborisovich
suggested changes
Mar 11, 2022
aborisovich
approved these changes
Mar 13, 2022
Contributor
aborisovich
left a comment
aborisovich
left a comment
There was a problem hiding this comment.
Contributor answered all my concerns 👍
lgirdwood
approved these changes
Mar 14, 2022
Member
Collaborator
Author
|
There is a single, |
|
CI green, good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4 commits. Main one: restore ability to override CI