xtensa-build-zephyr.py: un-hardcode execute_command() wrapper #5516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicating all parameters of subprocess.run() is not just tedious and error-prone, it makes the script compatible only with a range of specific Python versions. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Collaborator
Author
|
https://sof-ci.01.org/sofpr/PR5516/build12315/devicetest/?model=TGLU_RVP_SDW&testcase=check-suspend-resume-with-playback-5 is the well known thesofproject/linux/issues/3459. The rest is some usual suspend/resume TIMEOUT. Nothing is related to this PR. |
lgirdwood
approved these changes
Mar 11, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@aborisovich any comments ?
aborisovich
approved these changes
Mar 13, 2022
Contributor
aborisovich
left a comment
aborisovich
left a comment
There was a problem hiding this comment.
What can I say, if I learned previously about *args/**kwargs, this would be in the script already ;-)
Thanks Marc!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicating all parameters of subprocess.run() is not just tedious and
error-prone, it makes the script compatible only with a range of
specific Python versions.
Signed-off-by: Marc Herbert marc.herbert@intel.com