Clean up all SHARED_DATA data
#5524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyakh
requested review from
RanderWang,
bhiregoudar,
dbaluta,
kuanhsuncheng,
lbetlej,
lgirdwood,
libinyang,
mmaka1,
plbossart,
sunilkumardommati and
yaochunhung
as code owners
Collaborator
Author
|
CI failures:
|
lgirdwood
reviewed
Mar 14, 2022
Collaborator
Author
@lgirdwood sure, the latest version is |
lgirdwood
approved these changes
Mar 15, 2022
Shared objects are placed into a separate section to make sure they don't share cache lines with core-local data. This must also be done in single-core configurations because those configurations perform uncached access and manage cache manually too. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
pipeline_posn is a name of a structure, a field in a structure, a static object and a local variable in several functions. Use a different name to at least avoid conflicting static and local variables. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
mn is a name of a structure, a field in a structure, a static object and a local variable in several functions. Use a different name to at least avoid conflicting static and local variables. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Access to objects, defined with a SHARED_DATA attribute should only be performed, using the platform_shared_get() function. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
notify_data is a name of a structure, a field in a structure, a static object and a local variable in several functions. Use a different name to at least avoid conflicting static and local variables. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Access to objects, defined with a SHARED_DATA attribute should only be performed, using the platform_shared_get() function. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Access to objects, defined with a SHARED_DATA attribute should only be performed, using the platform_shared_get() function. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Access to objects, defined with a SHARED_DATA attribute should only be performed, using the platform_shared_get() function. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
cache_to_uncache_init() is needed to convert addresses from cached to uncached aliases in a preprocessor-friendly way. Add it to all platforms. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Access to objects, defined with a SHARED_DATA attribute should only be performed, using the platform_shared_get() function at run-time or using cache_to_uncache_init() at initialisation time. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Access to objects, defined with a SHARED_DATA attribute should only be performed, using the platform_shared_get() function at run-time or using cache_to_uncache_init() at initialisation time. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Collaborator
Author
|
IC failures seem to be unrelated: a timeout in the IPC flood test on BYT and 2 failed suspend-resume with audio tests on an ADL platform https://sof-ci.01.org/sofpr/PR5524/build12463/devicetest/?model=TGLU_RVP_SDW&testcase=check-suspend-resume-with-playback-5 |
lgirdwood
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects, defined with a
SHARED_DATAattribute should go into a separate section in both single- and multi-core configurations. Access to them at run-time should only be performed via theplatform_shared_get()accessor and at initialisation time withcache_to_uncache_init()