Skip to content

ipc4: fix the compound ipc wait timeout #5547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mwasko merged 1 commit into from
Mar 21, 2022
Merged

ipc4: fix the compound ipc wait timeout #5547

mwasko merged 1 commit into from
Mar 21, 2022

Conversation

@rfredzim
Copy link
Collaborator

@rfredzim rfredzim commented Mar 15, 2022

The number of retries is too small to successfully handle some
compound IPC messages (in particular setting pipeline state to running
in case of multi-core distributed pipeline).

Signed-off-by: Rafal Redzimski rafal.f.redzimski@intel.com

@rfredzim
ipc4: fix the compound ipc wait timeout
20760d6 
The number of retries is too small to successfully handle some
compound IPC messages (in particular setting pipeline state to running
in case of multi-core distributed pipeline).

Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
@sofci
Copy link
Collaborator

sofci commented Mar 15, 2022

Can one of the admins verify this patch?

reply test this please to run this test once

@rfredzim
Copy link
Collaborator Author

rfredzim commented Mar 15, 2022

test this please
SOFCI TEST

@rfredzim
Copy link
Collaborator Author

rfredzim commented Mar 17, 2022 •
edited
Loading

@lgirdwood, @mmaka1 could you please review and approve?
This change is needed to successfully handle some ipc_compund messages.
In my case the previous timeout value was insufficient to handle set pipeline state for a pipeline for which modules instances were distributed to many cores and the test executed in FPGA environment (the boundary try_count value was 13, but I think it's reasonable to change it to a larger value like 30 in order to have significant buffer)

@lgirdwood
Copy link
Member

lgirdwood commented Mar 18, 2022

please test this

@lgirdwood
Copy link
Member

lgirdwood commented Mar 18, 2022

@rfredzim CI should be automatically running for you now. I know there was an outage a few days back, but please let me know if this is still an issue for new PRs.

@lgirdwood
Copy link
Member

lgirdwood commented Mar 18, 2022

@mmaka1 good for you ?

@mwasko mwasko merged commit cd0c1f9 into thesofproject:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lgirdwood lgirdwood lgirdwood approved these changes

@abonislawski abonislawski abonislawski approved these changes

@plbossart plbossart Awaiting requested review from plbossart plbossart is a code owner

@mmaka1 mmaka1 Awaiting requested review from mmaka1 mmaka1 is a code owner

@lbetlej lbetlej Awaiting requested review from lbetlej lbetlej is a code owner

@dbaluta dbaluta Awaiting requested review from dbaluta dbaluta is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rfredzim @sofci @lgirdwood @abonislawski @mwasko