Skip to content

Conversation

@lyakh
Copy link
Collaborator

@lyakh lyakh commented Mar 16, 2022

When the ll-scheduler is initialised and its private data is allocated, all fields of that data have to be initialised. Add a missing n_tasks initialisation.

When the ll-scheduler is initialised and its private data is
allocated, all fields of that data have to be initialised. Add a
missing n_tasks initialisation.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@lyakh lyakh requested a review from mrajwa as a code owner March 16, 2022 08:29
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kv2019i @mengdonglin fyi - needed for v2.1

@lgirdwood lgirdwood added this to the v2.1 milestone Mar 16, 2022
@lgirdwood lgirdwood merged commit 2e45906 into thesofproject:main Mar 16, 2022
@lgirdwood
Copy link
Member

@ujfalusi @plbossart fyi unrelated to this PR and reported by CI, looks like a display PM issue on BYT that cascades to FW (and SOF driver handles gracefully)

[  478.826771] kernel: ------------[ cut here ]------------
[  478.826780] kernel: i915 0000:00:02.0: drm_WARN_ON((intel_uncore_read(&dev_priv->uncore, ((const i915_reg_t){ .reg = (0x130090) })) & mask) != mask)
[  478.826831] kernel: WARNING: CPU: 3 PID: 51 at drivers/gpu/drm/i915/vlv_suspend.c:405 vlv_suspend_complete+0x6a6/0x6c0 [i915]
[  478.826994] kernel: Modules linked in: snd_usb_audio snd_usbmidi_lib snd_hwdep snd_sof_pci_intel_tgl snd_sof_pci_intel_icl snd_sof_pci_intel_cnl snd_sof_pci_intel_apl snd_sof_intel_hda_common snd_sof_pci_intel_tng snd_sof_pci snd_sof_acpi_intel_bdw snd_sof_ipc_msg_injector snd_sof_ipc_flood_test snd_sof_nocodec snd_sof_acpi_intel_byt snd_sof_intel_atom snd_sof_xtensa_dsp snd_soc_acpi_intel_match snd_soc_acpi snd_intel_dspcfg snd_sof_acpi snd_sof snd_sof_utils snd_soc_core snd_compress snd_pcm fuse ledtrig_audio i915 intel_soc_dts_thermal intel_soc_dts_iosf intel_powerclamp drm_kms_helper snd_seq_midi mei_txe snd_seq_midi_event ttm mei snd_rawmidi snd_seq snd_seq_device snd_timer snd soundcore squashfs drm drm_panel_orientation_quirks efivarfs igb xhci_pci mmc_block i2c_algo_bit xhci_hcd sdhci_acpi sdhci [last unloaded: snd_pcm]
[  478.827174] kernel: CPU: 3 PID: 51 Comm: kworker/3:1 Tainted: G        W         5.17.0-rc1-daily-nocodec-20220315-0-gd2937505b7b5 #dev
[  478.827182] kernel: Hardware name: ADI Minnowboard Turbot D0 PLATFORM/MinnowBoard Turbot, BIOS MNW2MAX1.X64.0097.R01.1709211052 09/21/2017
[  478.827188] kernel: Workqueue: pm pm_runtime_work
[  478.827201] kernel: RIP: 0010:vlv_suspend_complete+0x6a6/0x6c0 [i915]
[  478.827339] kernel: Code: 8b 7d 08 4c 8b 6f 50 4d 85 ed 74 25 e8 23 01 24 cc 48 c7 c1 b8 c9 72 c0 4c 89 ea 48 c7 c7 30 7c 75 c0 48 89 c6 e8 6a 84 77 cc <0f> 0b e9 d5 f9 ff ff 4c 8b 2f eb d6 66 66 2e 0f 1f 84 00 00 00 00
[  478.827345] kernel: RSP: 0018:ffffb236c0247ce8 EFLAGS: 00010282
[  478.827353] kernel: RAX: 0000000000000000 RBX: ffff95cdcbd10000 RCX: 0000000000000000
[  478.827358] kernel: RDX: 0000000000000001 RSI: ffffffff8d5ee699 RDI: 00000000ffffffff
[  478.827363] kernel: RBP: ffff95cdcbd10000 R08: 0000000000000000 R09: ffffb236c0247b10
[  478.827369] kernel: R10: 000000000013a0e8 R11: 000000000013a148 R12: ffff95cdcbd10ff0
[  478.827373] kernel: R13: ffff95cdc19e9870 R14: ffff95cdc1a08000 R15: 0000000000000000
[  478.827379] kernel: FS:  0000000000000000(0000) GS:ffff95ce34c00000(0000) knlGS:0000000000000000
[  478.827384] kernel: CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  478.827390] kernel: CR2: 00007f5c39eaa388 CR3: 000000000a98e000 CR4: 00000000001006e0
[  478.827395] kernel: Call Trace:
[  478.827402] kernel:  
[  478.827415] kernel:  intel_runtime_suspend+0x9c/0x1b0 [i915]
[  478.827557] kernel:  pci_pm_runtime_suspend+0x5a/0x160
[  478.827567] kernel:  ? pci_pm_runtime_resume+0x90/0x90
[  478.827576] kernel:  ? pci_pm_runtime_resume+0x90/0x90
[  478.827587] kernel:  __rpm_callback+0x44/0x160
[  478.827597] kernel:  ? pci_pm_runtime_resume+0x90/0x90
[  478.827608] kernel:  rpm_callback+0x59/0x70
[  478.827618] kernel:  ? pci_pm_runtime_resume+0x90/0x90
[  478.827625] kernel:  rpm_suspend+0x103/0x610
[  478.827647] kernel:  pm_runtime_work+0x8c/0xb0
[  478.827657] kernel:  process_one_work+0x29f/0x530
[  478.827684] kernel:  worker_thread+0x4d/0x3c0
[  478.827702] kernel:  ? process_one_work+0x530/0x530
[  478.827711] kernel:  kthread+0xf2/0x120
[  478.827719] kernel:  ? kthread_complete_and_exit+0x20/0x20
[  478.827806] kernel:  ret_from_fork+0x22/0x30
[  478.827845] kernel:  
[  478.827849] kernel: ---[ end trace 0000000000000000 ]---
[  479.232229] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: open stream 0 dir 1
[  479.232243] kernel: sof-audio-acpi-intel-byt 80860F28:00: period min 192 max 16384 bytes
[  479.232251] kernel: sof-audio-acpi-intel-byt 80860F28:00: period count 2 max 16
[  479.232257] kernel: sof-audio-acpi-intel-byt 80860F28:00: buffer max 65536 bytes
[  479.232616] kernel: sof-audio-acpi-intel-byt 80860F28:00: DAI config 0 matches pcm hw params
[  479.232625] kernel: sof-audio-acpi-intel-byt 80860F28:00: DAI config 0 matches pcm hw params
[  479.232631] kernel: sof-audio-acpi-intel-byt 80860F28:00: rate_min: 48000 rate_max: 48000
[  479.232637] kernel: sof-audio-acpi-intel-byt 80860F28:00: channels_min: 2 channels_max: 2
[  479.232651] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: hw params stream 0 dir 1
[  479.232670] kernel: sof-audio-acpi-intel-byt 80860F28:00: stream_tag 0
[  479.232687] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx: 0x60010000: GLB_STREAM_MSG: PCM_PARAMS
[  479.233329] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx succeeded: 0x60010000: GLB_STREAM_MSG: PCM_PARAMS
[  479.233344] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: stream dir 1, posn mailbox offset is 1329816
[  479.233552] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: trigger stream 0 dir 1 cmd 1
[  479.233569] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx: 0x60040000: GLB_STREAM_MSG: TRIG_START
[  479.233692] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx succeeded: 0x60040000: GLB_STREAM_MSG: TRIG_START
[  479.470475] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: open stream 0 dir 0
[  479.470488] kernel: sof-audio-acpi-intel-byt 80860F28:00: period min 192 max 16384 bytes
[  479.470496] kernel: sof-audio-acpi-intel-byt 80860F28:00: period count 2 max 16
[  479.470502] kernel: sof-audio-acpi-intel-byt 80860F28:00: buffer max 65536 bytes
[  479.471276] kernel: sof-audio-acpi-intel-byt 80860F28:00: DAI config 0 matches pcm hw params
[  479.471287] kernel: sof-audio-acpi-intel-byt 80860F28:00: DAI config 0 matches pcm hw params
[  479.471293] kernel: sof-audio-acpi-intel-byt 80860F28:00: rate_min: 48000 rate_max: 48000
[  479.471300] kernel: sof-audio-acpi-intel-byt 80860F28:00: channels_min: 2 channels_max: 2
[  479.471314] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: hw params stream 0 dir 0
[  479.471336] kernel: sof-audio-acpi-intel-byt 80860F28:00: stream_tag 0
[  479.471352] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx: 0x60010000: GLB_STREAM_MSG: PCM_PARAMS
[  479.472140] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx succeeded: 0x60010000: GLB_STREAM_MSG: PCM_PARAMS
[  479.472153] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: stream dir 0, posn mailbox offset is 1329740
[  479.472367] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: trigger stream 0 dir 0 cmd 1
[  479.472382] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx: 0x60040000: GLB_STREAM_MSG: TRIG_START
[  479.496127] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: open stream 1 dir 0
[  479.496141] kernel: sof-audio-acpi-intel-byt 80860F28:00: period min 192 max 16384 bytes
[  479.496149] kernel: sof-audio-acpi-intel-byt 80860F28:00: period count 2 max 16
[  479.496155] kernel: sof-audio-acpi-intel-byt 80860F28:00: buffer max 65536 bytes
[  479.496516] kernel: sof-audio-acpi-intel-byt 80860F28:00: DAI config 0 matches pcm hw params
[  479.496525] kernel: sof-audio-acpi-intel-byt 80860F28:00: DAI config 0 matches pcm hw params
[  479.496531] kernel: sof-audio-acpi-intel-byt 80860F28:00: rate_min: 48000 rate_max: 48000
[  479.496538] kernel: sof-audio-acpi-intel-byt 80860F28:00: channels_min: 2 channels_max: 2
[  479.496550] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: hw params stream 1 dir 0
[  479.496571] kernel: sof-audio-acpi-intel-byt 80860F28:00: stream_tag 0
[  479.913658] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: trigger stream 0 dir 1 cmd 0
[  479.977102] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx timed out for 0x60040000 (msg/reply size: 12/12)
[  479.977498] kernel: sof-audio-acpi-intel-byt 80860F28:00: preventing DSP entering D3 state to preserve context
[  479.977519] kernel: sof-audio-acpi-intel-byt 80860F28:00: ------------[ DSP dump start ]------------
[  479.977663] kernel: sof-audio-acpi-intel-byt 80860F28:00: Firmware exception
[  479.977898] kernel: sof-audio-acpi-intel-byt 80860F28:00: fw_state: SOF_FW_BOOT_COMPLETE (6)
[  479.978101] kernel: sof-audio-acpi-intel-byt 80860F28:00: unexpected fault 0x600a0008 trace 0x00000000
[  479.978256] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: ipc host -> DSP: pending no complete no raw 0x8000000000000000
[  479.978335] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: mask host: pending no complete no raw 0x0
[  479.978381] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: ipc DSP -> host: pending no complete yes raw 0x600a0008
[  479.978433] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: mask DSP: pending no complete no raw 0x0
[  479.978478] kernel: sof-audio-acpi-intel-byt 80860F28:00: ------------[ DSP dump end ]------------
[  479.978540] kernel: sof-audio-acpi-intel-byt 80860F28:00: ASoC: error at soc_component_trigger on 80860F28:00: -110
[  479.978596] kernel:  PCM: ASoC: trigger FE cmd: 1 failed: -110
[  479.978605] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: trace IO error
[  479.978618] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx: 0x60010000: GLB_STREAM_MSG: PCM_PARAMS
[  479.978668] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: trigger stream 0 dir 0 cmd 0
[  480.481270] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx timed out for 0x60010000 (msg/reply size: 108/20)
[  480.481376] kernel: sof-audio-acpi-intel-byt 80860F28:00: preventing DSP entering D3 state to preserve context
[  480.481388] kernel: sof-audio-acpi-intel-byt 80860F28:00: ------------[ DSP dump start ]------------
[  480.481466] kernel: sof-audio-acpi-intel-byt 80860F28:00: Firmware exception
[  480.481528] kernel: sof-audio-acpi-intel-byt 80860F28:00: fw_state: SOF_FW_BOOT_COMPLETE (6)
[  480.481658] kernel: sof-audio-acpi-intel-byt 80860F28:00: unexpected fault 0x600a0008 trace 0x00000000
[  480.481740] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: ipc host -> DSP: pending no complete no raw 0x8000000000000000
[  480.481908] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: mask host: pending no complete no raw 0x0
[  480.481994] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: ipc DSP -> host: pending no complete yes raw 0x600a0008
[  480.482085] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: mask DSP: pending no complete no raw 0x0
[  480.482167] kernel: sof-audio-acpi-intel-byt 80860F28:00: ------------[ DSP dump end ]------------
[  480.482257] kernel: sof-audio-acpi-intel-byt 80860F28:00: HW params ipc failed for stream 0
[  480.482333] kernel: sof-audio-acpi-intel-byt 80860F28:00: ASoC: error at snd_soc_pcm_component_hw_params on 80860F28:00: -110
[  480.482437] kernel:  PCM Deep Buffer: ASoC: __soc_pcm_hw_params() failed (-110)
[  480.482446] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx: 0x60050000: GLB_STREAM_MSG: TRIG_STOP
[  480.482505] kernel:  PCM Deep Buffer: ASoC: dpcm_fe_dai_hw_params failed (-110)
[  480.482580] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: free stream 1 dir 0
[  480.483616] kernel: sof-audio-acpi-intel-byt 80860F28:00: pcm: close stream 1 dir 0
[  480.985326] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx timed out for 0x60050000 (msg/reply size: 12/12)
[  480.985514] kernel: sof-audio-acpi-intel-byt 80860F28:00: preventing DSP entering D3 state to preserve context
[  480.985535] kernel: sof-audio-acpi-intel-byt 80860F28:00: ------------[ DSP dump start ]------------
[  480.985680] kernel: sof-audio-acpi-intel-byt 80860F28:00: Firmware exception
[  480.985905] kernel: sof-audio-acpi-intel-byt 80860F28:00: fw_state: SOF_FW_BOOT_COMPLETE (6)
[  480.986107] kernel: sof-audio-acpi-intel-byt 80860F28:00: unexpected fault 0x600a0008 trace 0x00000000
[  480.986260] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: ipc host -> DSP: pending no complete no raw 0x8000000000000000
[  480.986439] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: mask host: pending no complete no raw 0x0
[  480.986594] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: ipc DSP -> host: pending no complete yes raw 0x600a0008
[  480.986762] kernel: sof-audio-acpi-intel-byt 80860F28:00: error: mask DSP: pending no complete no raw 0x0
[  480.986977] kernel: sof-audio-acpi-intel-byt 80860F28:00: ------------[ DSP dump end ]------------
[  480.987173] kernel: sof-audio-acpi-intel-byt 80860F28:00: ASoC: error at soc_component_trigger on 80860F28:00: -110
[  480.987246] kernel: sof-audio-acpi-intel-byt 80860F28:00: ipc tx: 0x60050000: GLB_STREAM_MSG: TRIG_STOP
[  480.987343] kernel:  PCM: ASoC: trigger FE cmd: 0 failed: -110

@ujfalusi
Copy link
Contributor

@lgirdwood, looks like we have several IPC messages timing out, so firmware is not responding...

@lyakh lyakh deleted the zll branch March 16, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants