ipc4: add support for voice recorder in windows 10 #5563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanderWang
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
requested changes
Mar 18, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@marcinszkudlinski @tmleman @rfredzim any comments ?
RanderWang
force-pushed
the
ipc4_capture
branch
from
4073933 to
d1b1437
Compare
lgirdwood
approved these changes
Mar 21, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@RanderWang thanks, now I follow. @tmleman @marcinszkudlinski any comments ?
tmleman
requested changes
Mar 21, 2022
RanderWang
force-pushed
the
ipc4_capture
branch
3 times, most recently
from
816a125 to
529575f
Compare
In ipc3 path, host driver sends pcm_hw_param message to fw and direction is included. The direction is set to each component after pipeline is complete. There is no such ipc message for ipc4 path and direction can only be figured out from dai gateway type if there is one. Ipc4 path gets direction from dai component and set it to each component after connected pipeline are complete. We skip the host copier to host copier case. Signed-off-by: Rander Wang <rander.wang@intel.com>
For alh, link dma and host gateway, the conversion function is based on direction. For example to convert s24c32 to s32c32 with alh, it should be function of convert_s24_to_s32 for playback, but it is a simple copy function for capture since the valid sample bits are set in msb 24bits like 0xdddddd00 for alh gateway. The combination of all conditions is very huge but only part of them are used in real case. This patch only supports some patterns in our test case and is not complete. It will be enhanced in future. Signed-off-by: Rander Wang <rander.wang@intel.com>
Currently error is reported for both active and paused state when pipeline is set to reset. For ipc4 case, it is good to switch from pause to reset. The switch from active to reset is not permitted for both ipc3 and ipc4. This patch uses different log for active and paused state. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
force-pushed
the
ipc4_capture
branch
from
529575f to
b693e6e
Compare
Collaborator
Author
|
@tmleman please test this PR, I updated it . thanks |
In ipc4 pipeline can't be reset when the source and current component is in the same pipeline and it is active. This is different with ipc3. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
force-pushed
the
ipc4_capture
branch
from
b693e6e to
e5a5a9d
Compare
tmleman
approved these changes
Mar 28, 2022
Fix a error found by ipc4 Linux driver. Some component pipeline may be incomplete, so the pipeline is not updated to the component. Skip this pipeline and return dai of null. Signed-off-by: Rander Wang <rander.wang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Voice recorder can capture voice and save it to hard disk. This patch fixes some bugs and add support of format conversion used by it.