ipc4: add volume_params support #5567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RanderWang
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
lgirdwood
approved these changes
Mar 18, 2022
Member
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
LGTM, but I'm no IPC4 expert - @marcinszkudlinski @tmleman @rfredzim any comments ?
Fix fw error found by windows audio setting test. In ipc3 path, host driver sends ipc_hw_params message to fw but in ipc4 path fw needs to build component params from component config. This patch add params function for volume. Signed-off-by: Rander Wang <rander.wang@intel.com>
RanderWang
force-pushed
the
ipc4_vol_params
branch
from
4ee905d to
a453ed9
Compare
marcinszkudlinski
approved these changes
Mar 21, 2022
tmleman
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fw error found by windows audio setting test.
In ipc3 path, host driver sends ipc_hw_params message
to fw but in ipc4 path fw needs to build component
params from component config.
This patch add params function for volume.
Signed-off-by: Rander Wang rander.wang@intel.com